core/fxcrt/extension.h - Issue 1951653002: Return bool rather than bitwise-and for FX_BOOL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/extension.h

Issue 1951653002: Return bool rather than bitwise-and for FX_BOOL (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: More bool, fix nits. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcrt/extension.h

diff --git a/core/fxcrt/extension.h b/core/fxcrt/extension.h

index a8a099c664bb567f1d75bf623b4d4f028a1b1c30..b0e7b9e117ef519b65524001eb00cbc2ea3f5c7f 100644

--- a/core/fxcrt/extension.h

+++ b/core/fxcrt/extension.h

@@ -241,7 +241,7 @@ class CFX_MemoryStream final : public IFX_MemoryStream {

}

FX_BOOL Flush() override { return TRUE; }

FX_BOOL IsConsecutive() const override {

- return m_dwFlags & FX_MEMSTREAM_Consecutive;

+ return !!(m_dwFlags & FX_MEMSTREAM_Consecutive);

}

void EstimateSize(size_t nInitSize, size_t nGrowSize) override {

if (m_dwFlags & FX_MEMSTREAM_Consecutive) {

« no previous file with comments | « core/fpdfapi/fpdf_render/fpdf_render_image.cpp ('k') | core/fxge/ge/fx_ge_text.cpp » ('j') | no next file with comments »