xfa/fwl/core/fwl_formimp.h - Issue 1951653002: Return bool rather than bitwise-and for FX_BOOL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/core/fwl_formimp.h

Issue 1951653002: Return bool rather than bitwise-and for FX_BOOL (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: More bool, fix nits. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/core/fwl_formimp.h

diff --git a/xfa/fwl/core/fwl_formimp.h b/xfa/fwl/core/fwl_formimp.h

index 4ee3e0ddae23687d00819e60563c5fdb914bdda5..d8bc80522e6fa8b148755c9adcd4f3aa94c67507 100644

--- a/xfa/fwl/core/fwl_formimp.h

+++ b/xfa/fwl/core/fwl_formimp.h

@@ -32,7 +32,7 @@ class CFWL_SysBtn {

m_dwState = 0;

}

- FX_BOOL IsDisabled() { return m_dwState & FWL_SYSBUTTONSTATE_Disabled; }

+ bool IsDisabled() { return !!(m_dwState & FWL_SYSBUTTONSTATE_Disabled); }

void SetNormal() { m_dwState &= 0xFFF0; }

void SetPressed() {

« no previous file with comments | « xfa/fwl/basewidget/fwl_listboximp.cpp ('k') | xfa/fwl/core/fwl_noteimp.cpp » ('j') | no next file with comments »