Delete blink::WebGraphicsContext3D and cc_blink::ContextProviderWebContext

Delete blink::WebGraphicsContext3D and cc_blink::ContextProviderWebContext

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel;tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/ae04f52ea689d1a31e7e4529166be3ded508ab6d
Cr-Commit-Position: refs/heads/master@{#390825}

[danakj, 2016-04-29 21:50:17]

Description was changed from

==========
Delete blink::WebGraphicsContext3D.

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
==========

to

==========
Delete blink::WebGraphicsContext3D.

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-04-29 21:50:18]

Description was changed from

==========
Delete blink::WebGraphicsContext3D.

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Delete blink::WebGraphicsContext3D.

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[danakj, 2016-04-29 21:50:19]

Description was changed from

==========
Delete blink::WebGraphicsContext3D.

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Delete blink::WebGraphicsContext3D.

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[danakj, 2016-04-29 21:50:24]

Description was changed from

==========
Delete blink::WebGraphicsContext3D.

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Delete blink::WebGraphicsContext3D and cc_blink::ContextProviderWebContext

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
==========

[danakj, 2016-04-29 21:52:27]

Description was changed from

==========
Delete blink::WebGraphicsContext3D and cc_blink::ContextProviderWebContext

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
==========

to

==========
Delete blink::WebGraphicsContext3D and cc_blink::ContextProviderWebContext

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-04-29 21:52:29]

Description was changed from

==========
Delete blink::WebGraphicsContext3D and cc_blink::ContextProviderWebContext

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Delete blink::WebGraphicsContext3D and cc_blink::ContextProviderWebContext

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[danakj, 2016-04-29 21:52:36]

Description was changed from

==========
Delete blink::WebGraphicsContext3D and cc_blink::ContextProviderWebContext

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Delete blink::WebGraphicsContext3D and cc_blink::ContextProviderWebContext

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[danakj, 2016-04-29 21:54:08]

+enne for owners of cc and core and stuff

[danakj, 2016-04-29 21:54:18]

Description was changed from

==========
Delete blink::WebGraphicsContext3D and cc_blink::ContextProviderWebContext

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Delete blink::WebGraphicsContext3D and cc_blink::ContextProviderWebContext

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[danakj, 2016-04-29 21:54:18]

danakj@chromium.org changed reviewers:
+ enne@chromium.org

[enne (OOO), 2016-04-29 21:55:33]

Deleting code super lgtm

[danakj, 2016-04-29 21:55:59]

chrishtr can you review platform/graphics and public please

[chrishtr, 2016-04-29 22:03:39]

lgtm

[Zhenyao Mo, 2016-04-29 22:05:09]

awesome.

modules/webgl lgtm

[danakj, 2016-04-29 22:06:07]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 22:06:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1935783002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1935783002/40001

[darin (slow to review), 2016-04-29 22:06:41]

darin@chromium.org changed reviewers:
+ darin@chromium.org, zmo@chromium.org

[darin (slow to review), 2016-04-29 22:06:42]

Glorious! LGTM

[danakj, 2016-04-29 22:15:35]

Description was changed from

==========
Delete blink::WebGraphicsContext3D and cc_blink::ContextProviderWebContext

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Delete blink::WebGraphicsContext3D and cc_blink::ContextProviderWebContext

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel;tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-04-29 22:15:43]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-04-29 22:15:50]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 22:16:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1935783002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1935783002/40001

[commit-bot: I haz the power, 2016-04-29 22:27:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 22:27:15]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[danakj, 2016-04-29 22:40:24]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 22:40:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1935783002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1935783002/60001

[danakj, 2016-04-30 00:17:46]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-04-30 00:17:52]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-04-30 00:17:53]

The patchset sent to the CQ was uploaded after l-g-t-m from darin@chromium.org,
enne@chromium.org, chrishtr@chromium.org, zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/1935783002/#ps60001
(title: "rmwgc3d: export")

[commit-bot: I haz the power, 2016-04-30 00:18:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1935783002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1935783002/60001

[Fady Samuel, 2016-04-30 00:22:27]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2016-04-30 00:22:28]

https://codereview.chromium.org/1935783002/diff/60001/content/common/gpu/clie...
File content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
(right):

https://codereview.chromium.org/1935783002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h:25:
#include "third_party/WebKit/public/platform/WebString.h"
Drive by nit: Is this include still necessary?

[danakj, 2016-04-30 00:25:54]

https://codereview.chromium.org/1935783002/diff/60001/content/common/gpu/clie...
File content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
(right):

https://codereview.chromium.org/1935783002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h:25:
#include "third_party/WebKit/public/platform/WebString.h"
On 2016/04/30 00:22:28, Fady Samuel wrote:
> Drive by nit: Is this include still necessary?

Probably not, I'm deleting this whole file though so it'll disappear soon.

[commit-bot: I haz the power, 2016-04-30 01:02:38]

Description was changed from

==========
Delete blink::WebGraphicsContext3D and cc_blink::ContextProviderWebContext

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel;tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Delete blink::WebGraphicsContext3D and cc_blink::ContextProviderWebContext

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel;tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-04-30 01:02:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-30 17:30:41]

Patchset 4 (id:??) landed as
https://crrev.com/ae04f52ea689d1a31e7e4529166be3ded508ab6d
Cr-Commit-Position: refs/heads/master@{#390825}

[commit-bot: I haz the power, 2016-04-30 18:03:50]

Description was changed from

==========
Delete blink::WebGraphicsContext3D and cc_blink::ContextProviderWebContext

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel;tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Delete blink::WebGraphicsContext3D and cc_blink::ContextProviderWebContext

The provider only returns nullptr now, so this is all dead.

R=chrishtr@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel;tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/ae04f52ea689d1a31e7e4529166be3ded508ab6d
Cr-Commit-Position: refs/heads/master@{#390825}
==========

[Ken Russell (switch to Gerrit), 2016-05-02 18:27:00]

Sorry I wasn't around to review this but thank you for untangling this mess of
code. Excellent. LGTM

[piman, 2016-05-02 18:42:45]

Belated \o/

On Fri, Apr 29, 2016 at 2:54 PM, <danakj@chromium.org> wrote:

> Reviewers: chrishtr, Ken Russell OOO till 5-2-2016
> CL: https://codereview.chromium.org/1935783002/
>
> Message:
> +enne for owners of cc and core and stuff
>
> Description:
> Delete blink::WebGraphicsContext3D and cc_blink::ContextProviderWebContext
>
> The provider only returns nullptr now, so this is all dead.
>
> R=chrishtr@chromium.org, kbr@chromium.org
> BUG=584497
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@sharegroup
>
> Affected files (+22, -195 lines):
> M cc/blink/BUILD.gn
> D cc/blink/context_provider_web_context.h
> M cc/blink/web_compositor_support_impl.h
> M cc/blink/web_external_texture_layer_impl.cc
> M components/test_runner/test_plugin.h
> M components/test_runner/test_plugin.cc
> M content/browser/DEPS
> M content/browser/compositor/image_transport_factory.h
> M content/browser/renderer_host/render_widget_host_view_android.h
> M content/common/DEPS
> M content/common/gpu/client/context_provider_command_buffer.h
> M content/common/gpu/client/context_provider_command_buffer.cc
> M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
> M content/renderer/media/webmediaplayer_ms.cc
> M content/renderer/render_frame_impl.cc
> M content/renderer/render_thread_impl.h
> M content/renderer/render_view_impl.h
> M content/renderer/render_widget.cc
> M content/renderer/render_widget_fullscreen_pepper.cc
> M content/renderer/renderer_blink_platform_impl.h
> M content/renderer/renderer_blink_platform_impl.cc
> M content/renderer/webgraphicscontext3d_provider_impl.h
> M content/renderer/webgraphicscontext3d_provider_impl.cc
> M gpu/ipc/client/gpu_context_tests.h
> M third_party/WebKit/Source/core/html/HTMLVideoElement.cpp
> M third_party/WebKit/Source/core/testing/Internals.cpp
> M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
> M third_party/WebKit/Source/modules/webgl/WebGLContextGroup.h
> M third_party/WebKit/Source/modules/webgl/WebGLContextObject.h
> M third_party/WebKit/Source/modules/webgl/WebGLObject.h
> M third_party/WebKit/Source/modules/webgl/WebGLObject.cpp
> M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
> M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
> M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h
> M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
> M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp
> M third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp
> M third_party/WebKit/Source/platform/graphics/ImageBuffer.h
> M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp
> M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
> M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
> M third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp
> M
> third_party/WebKit/Source/platform/graphics/gpu/SharedContextRateLimiter.cpp
> M third_party/WebKit/public/blink_headers.gypi
> M third_party/WebKit/public/platform/Platform.h
> M third_party/WebKit/public/platform/WebCompositorSupport.h
> D third_party/WebKit/public/platform/WebGraphicsContext3D.h
> M third_party/WebKit/public/platform/WebGraphicsContext3DProvider.h
> M third_party/WebKit/public/web/WebViewClient.h
>
>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[piman, 2016-05-02 18:42:45]

Belated \o/

On Fri, Apr 29, 2016 at 2:54 PM, <danakj@chromium.org> wrote:

> Reviewers: chrishtr, Ken Russell OOO till 5-2-2016
> CL: https://codereview.chromium.org/1935783002/
>
> Message:
> +enne for owners of cc and core and stuff
>
> Description:
> Delete blink::WebGraphicsContext3D and cc_blink::ContextProviderWebContext
>
> The provider only returns nullptr now, so this is all dead.
>
> R=chrishtr@chromium.org, kbr@chromium.org
> BUG=584497
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@sharegroup
>
> Affected files (+22, -195 lines):
> M cc/blink/BUILD.gn
> D cc/blink/context_provider_web_context.h
> M cc/blink/web_compositor_support_impl.h
> M cc/blink/web_external_texture_layer_impl.cc
> M components/test_runner/test_plugin.h
> M components/test_runner/test_plugin.cc
> M content/browser/DEPS
> M content/browser/compositor/image_transport_factory.h
> M content/browser/renderer_host/render_widget_host_view_android.h
> M content/common/DEPS
> M content/common/gpu/client/context_provider_command_buffer.h
> M content/common/gpu/client/context_provider_command_buffer.cc
> M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
> M content/renderer/media/webmediaplayer_ms.cc
> M content/renderer/render_frame_impl.cc
> M content/renderer/render_thread_impl.h
> M content/renderer/render_view_impl.h
> M content/renderer/render_widget.cc
> M content/renderer/render_widget_fullscreen_pepper.cc
> M content/renderer/renderer_blink_platform_impl.h
> M content/renderer/renderer_blink_platform_impl.cc
> M content/renderer/webgraphicscontext3d_provider_impl.h
> M content/renderer/webgraphicscontext3d_provider_impl.cc
> M gpu/ipc/client/gpu_context_tests.h
> M third_party/WebKit/Source/core/html/HTMLVideoElement.cpp
> M third_party/WebKit/Source/core/testing/Internals.cpp
> M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
> M third_party/WebKit/Source/modules/webgl/WebGLContextGroup.h
> M third_party/WebKit/Source/modules/webgl/WebGLContextObject.h
> M third_party/WebKit/Source/modules/webgl/WebGLObject.h
> M third_party/WebKit/Source/modules/webgl/WebGLObject.cpp
> M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
> M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
> M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h
> M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
> M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp
> M third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp
> M third_party/WebKit/Source/platform/graphics/ImageBuffer.h
> M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp
> M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
> M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
> M third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp
> M
> third_party/WebKit/Source/platform/graphics/gpu/SharedContextRateLimiter.cpp
> M third_party/WebKit/public/blink_headers.gypi
> M third_party/WebKit/public/platform/Platform.h
> M third_party/WebKit/public/platform/WebCompositorSupport.h
> D third_party/WebKit/public/platform/WebGraphicsContext3D.h
> M third_party/WebKit/public/platform/WebGraphicsContext3DProvider.h
> M third_party/WebKit/public/web/WebViewClient.h
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.