Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2945)

Unified Diff: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h

Issue 1935783002: Delete blink::WebGraphicsContext3D and cc_blink::ContextProviderWebContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sharegroup
Patch Set: rmwgc3d: export Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
diff --git a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
index 1ce1a9225bda055374c1908e8a6d4f36443d03b0..fcfc7d949c8a3bc02e86fdbc775c149c65c180e8 100644
--- a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
+++ b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
@@ -22,7 +22,6 @@
#include "gpu/command_buffer/common/gles2_cmd_utils.h"
#include "gpu/ipc/client/command_buffer_proxy_impl.h"
#include "gpu/ipc/common/surface_handle.h"
-#include "third_party/WebKit/public/platform/WebGraphicsContext3D.h"
#include "third_party/WebKit/public/platform/WebString.h"
Fady Samuel 2016/04/30 00:22:28 Drive by nit: Is this include still necessary?
danakj 2016/04/30 00:25:54 Probably not, I'm deleting this whole file though
#include "ui/gl/gpu_preference.h"
#include "url/gurl.h"
@@ -44,8 +43,7 @@ class ShareGroup;
namespace content {
-class WebGraphicsContext3DCommandBufferImpl
- : public NON_EXPORTED_BASE(blink::WebGraphicsContext3D) {
+class WebGraphicsContext3DCommandBufferImpl {
public:
enum MappedMemoryReclaimLimit {
kNoLimit = 0,
@@ -72,7 +70,7 @@ class WebGraphicsContext3DCommandBufferImpl
gfx::GpuPreference gpu_preference,
bool automatic_flushes);
- ~WebGraphicsContext3DCommandBufferImpl() override;
+ CONTENT_EXPORT ~WebGraphicsContext3DCommandBufferImpl();
gpu::CommandBufferProxyImpl* GetCommandBufferProxy() {
return command_buffer_.get();
« no previous file with comments | « content/common/gpu/client/context_provider_command_buffer.cc ('k') | content/renderer/media/webmediaplayer_ms.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698