Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1918143007: Updated Blink WebVR interfaces to WebVR v1 spec (Closed)

Created:
4 years, 7 months ago by bajones
Modified:
4 years, 7 months ago
Reviewers:
haraken, Mike West
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@webvr_mojo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updated Blink WebVR interfaces to WebVR v1 spec BUG=389343 Committed: https://crrev.com/5c3db6e201646bd7d7bf5b8bd9addfe582d260c2 Cr-Commit-Position: refs/heads/master@{#392357}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Total comments: 1

Patch Set 4 : Removed [GarbageCollected] #

Patch Set 5 : Fixed layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+961 lines, -996 lines) Patch
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 6 chunks +37 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 2 3 5 chunks +20 lines, -19 lines 0 comments Download
D third_party/WebKit/Source/modules/vr/HMDVRDevice.h View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/Source/modules/vr/HMDVRDevice.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/Source/modules/vr/HMDVRDevice.idl View 1 chunk +0 lines, -19 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/NavigatorVR.h View 1 chunk +53 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/vr/NavigatorVR.cpp View 1 2 5 chunks +28 lines, -21 lines 0 comments Download
A + third_party/WebKit/Source/modules/vr/NavigatorVR.idl View 1 chunk +2 lines, -1 line 0 comments Download
D third_party/WebKit/Source/modules/vr/NavigatorVRDevice.h View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/Source/modules/vr/NavigatorVRDevice.cpp View 1 2 1 chunk +0 lines, -94 lines 0 comments Download
D third_party/WebKit/Source/modules/vr/NavigatorVRDevice.idl View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/Source/modules/vr/PositionSensorVRDevice.h View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/Source/modules/vr/PositionSensorVRDevice.cpp View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/Source/modules/vr/PositionSensorVRDevice.idl View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/Source/modules/vr/VRDevice.h View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/Source/modules/vr/VRDevice.cpp View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/Source/modules/vr/VRDevice.idl View 1 chunk +0 lines, -21 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/VRDisplay.h View 1 chunk +106 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 1 chunk +199 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/VRDisplay.idl View 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/VRDisplayCapabilities.h View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/VRDisplayCapabilities.cpp View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/VRDisplayCapabilities.idl View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/VRDisplayCollection.h View 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/VRDisplayCollection.cpp View 1 chunk +53 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VREyeParameters.h View 1 chunk +15 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VREyeParameters.cpp View 1 chunk +16 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VREyeParameters.idl View 1 chunk +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/modules/vr/VRHardwareUnit.h View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/WebKit/Source/modules/vr/VRHardwareUnit.cpp View 1 chunk +0 lines, -108 lines 0 comments Download
D third_party/WebKit/Source/modules/vr/VRHardwareUnitCollection.h View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/Source/modules/vr/VRHardwareUnitCollection.cpp View 1 chunk +0 lines, -65 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/VRLayer.idl View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/VRPose.h View 1 chunk +50 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/VRPose.cpp View 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/VRPose.idl View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/modules/vr/VRPositionState.h View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/Source/modules/vr/VRPositionState.cpp View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/Source/modules/vr/VRPositionState.idl View 1 chunk +0 lines, -16 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/VRStageParameters.h View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/VRStageParameters.cpp View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/VRStageParameters.idl View 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 38 (19 generated)
bajones
Updated the WebVR Blink interface to the 1.0 version of the spec (https://mozvr.com/webvr-spec/) There's some ...
4 years, 7 months ago (2016-05-06 21:01:56 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918143007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918143007/40001
4 years, 7 months ago (2016-05-06 22:15:44 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/224973) win_chromium_rel_ng on ...
4 years, 7 months ago (2016-05-06 23:33:47 UTC) #6
haraken
LGTM
4 years, 7 months ago (2016-05-07 09:39:41 UTC) #7
haraken
https://codereview.chromium.org/1918143007/diff/40001/third_party/WebKit/Source/modules/vr/VRPose.idl File third_party/WebKit/Source/modules/vr/VRPose.idl (right): https://codereview.chromium.org/1918143007/diff/40001/third_party/WebKit/Source/modules/vr/VRPose.idl#newcode8 third_party/WebKit/Source/modules/vr/VRPose.idl:8: GarbageCollected, [GarbageCollected] is no longer needed.
4 years, 7 months ago (2016-05-07 09:41:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918143007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918143007/60001
4 years, 7 months ago (2016-05-07 16:18:48 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/225157)
4 years, 7 months ago (2016-05-07 17:20:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918143007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918143007/60001
4 years, 7 months ago (2016-05-07 17:47:40 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/223858)
4 years, 7 months ago (2016-05-07 18:49:14 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918143007/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918143007/80001
4 years, 7 months ago (2016-05-07 20:52:31 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/225178)
4 years, 7 months ago (2016-05-07 21:43:50 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918143007/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918143007/80001
4 years, 7 months ago (2016-05-08 05:49:22 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/223910)
4 years, 7 months ago (2016-05-08 06:53:53 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918143007/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918143007/80001
4 years, 7 months ago (2016-05-08 20:30:43 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918143007/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918143007/80001
4 years, 7 months ago (2016-05-08 21:50:43 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/225267)
4 years, 7 months ago (2016-05-08 22:43:24 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918143007/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918143007/80001
4 years, 7 months ago (2016-05-09 16:29:01 UTC) #35
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-09 17:50:28 UTC) #36
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 17:52:41 UTC) #38
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5c3db6e201646bd7d7bf5b8bd9addfe582d260c2
Cr-Commit-Position: refs/heads/master@{#392357}

Powered by Google App Engine
This is Rietveld 408576698