DevTools: Fix all outstanding JavaScript style issues.

DevTools: Fix assorted JavaScript style issues.

https://codereview.chromium.org/1908863002/ introduces an eslint-based
style linter. This CL fixes all issues in the project.

BUG=605878
Committed: https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c
Cr-Commit-Position: refs/heads/master@{#389217}

[paulirish, 2016-04-22 09:44:47]

Description was changed from

==========
DevTools: Fix assorted JavaScript style issues.

BUG=605878
==========

to

==========
DevTools: Fix assorted JavaScript style issues.

https://codereview.chromium.org/1908863002/ introduces an eslint-based
style linter. This CL fixes all issues in the project.

BUG=605878
==========

[paulirish, 2016-04-22 09:46:50]

paulirish@chromium.org changed reviewers:
+ caseq@chromium.org, pfeldman@chromium.org

[paulirish, 2016-04-22 09:47:04]

The CQ bit was checked by paulirish@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 09:47:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907263002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907263002/1

[paulirish, 2016-04-22 09:50:50]

https://codereview.chromium.org/1907263002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js
(right):

https://codereview.chromium.org/1907263002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js:189: for
(var node = fromNode; node && node !== toNode;) {
This is the only change I feel bad about.

[paulirish, 2016-04-22 09:51:59]

PTAL. 
This addresses all legit javascript style issues (that I've found), in
preparation for enforcing the lint rules defined in
https://codereview.chromium.org/1908863002/

[commit-bot: I haz the power, 2016-04-22 11:10:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 11:10:30]

Dry run: This issue passed the CQ dry run.

[pfeldman, 2016-04-22 14:22:07]

lgtm

https://codereview.chromium.org/1907263002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
(right):

https://codereview.chromium.org/1907263002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js:84:
mapsToSourceCode: function(rawLocation) {
Can we enforce this guy to be on the next line?

https://codereview.chromium.org/1907263002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
(right):

https://codereview.chromium.org/1907263002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js:336:
/* eslint-disable yoda */
We can rewrite it to make lint happy - I also can't parse this.

[paulirish, 2016-04-22 18:28:50]

Thanks.

Our brace style is currently atypical and we cannot enforce it.
Details here: https://groups.google.com/forum/#!topic/eslint/Q9LZtYeWetA

We'll have to address brace style in a larger conversation about what style we
want to align with.

https://codereview.chromium.org/1907263002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
(right):

https://codereview.chromium.org/1907263002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js:84:
mapsToSourceCode: function(rawLocation) {
On 2016/04/22 at 14:22:07, pfeldman wrote:
> Can we enforce this guy to be on the next line?

ack

https://codereview.chromium.org/1907263002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
(right):

https://codereview.chromium.org/1907263002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js:336:
/* eslint-disable yoda */
On 2016/04/22 at 14:22:07, pfeldman wrote:
> We can rewrite it to make lint happy - I also can't parse this.

being addressed by kozyatinskiy. I'll remove the annotation

[paulirish, 2016-04-22 18:30:54]

The CQ bit was checked by paulirish@chromium.org

[paulirish, 2016-04-22 18:30:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1907263002/#ps20001
(title: "remove yoda disable. fix throw parens")

[commit-bot: I haz the power, 2016-04-22 18:31:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907263002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907263002/20001

[commit-bot: I haz the power, 2016-04-22 19:58:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 20:00:11]

Description was changed from

==========
DevTools: Fix assorted JavaScript style issues.

https://codereview.chromium.org/1908863002/ introduces an eslint-based
style linter. This CL fixes all issues in the project.

BUG=605878
==========

to

==========
DevTools: Fix assorted JavaScript style issues.

https://codereview.chromium.org/1908863002/ introduces an eslint-based
style linter. This CL fixes all issues in the project.

BUG=605878

Committed: https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c
Cr-Commit-Position: refs/heads/master@{#389217}
==========

[commit-bot: I haz the power, 2016-04-22 20:00:13]

Patchset 2 (id:??) landed as
https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c
Cr-Commit-Position: refs/heads/master@{#389217}