third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js - Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js

Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove yoda disable. fix throw parens Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js

index 5a867b894bf0f15183188babea1282b194666b9b..d03cecd41efe1c3b0588e224e54e5ae0fca702d0 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js

@@ -422,7 +422,7 @@ WebInspector.ProfileDataGridTree.prototype = {

var matcher = createPlainTextSearchRegex(query, "i");

- function matchesQuery(/*ProfileDataGridNode*/ profileDataGridNode)

+ function matchesQuery(/** @ProfileDataGridNode */ profileDataGridNode)

{

delete profileDataGridNode._searchMatchedSelfColumn;

delete profileDataGridNode._searchMatchedTotalColumn;

@@ -646,4 +646,4 @@ WebInspector.ProfileDataGridNode.Formatter.prototype = {

* @return {!Element}

linkifyNode: function(node) { }