third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js - Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove yoda disable. fix throw parens Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/BezierEditor.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

index b558a60ac8c839d57191751f945b5a2b9b9102dc..052c07272f2d14a2bfb07c721b7bd90b4daec668 100644

--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

@@ -176,7 +176,7 @@ WebInspector.ConsoleViewMessage.prototype = {

break;

default:

if (consoleMessage.parameters && consoleMessage.parameters.length === 1 && consoleMessage.parameters[0].type === "string")

- this._messageElement = this._tryFormatAsError(/**@type {string} */(consoleMessage.parameters[0].value));

+ this._messageElement = this._tryFormatAsError(/** @type {string} */(consoleMessage.parameters[0].value));

var args = consoleMessage.parameters || [consoleMessage.messageText];

this._messageElement = this._messageElement || this._format(args);

@@ -636,7 +636,7 @@ WebInspector.ConsoleViewMessage.prototype = {

span.appendChild(WebInspector.linkifyStringAsFragment(text));

event.consume(true);

}

- detailedLink._showDetailedForTest = showDetailed.bind(null, new MouseEvent('click'));

+ detailedLink._showDetailedForTest = showDetailed.bind(null, new MouseEvent("click"));

detailedLink.addEventListener("click", showDetailed, false);

}

@@ -844,7 +844,7 @@ WebInspector.ConsoleViewMessage.prototype = {

else if (typeof b !== "undefined") {

var toAppend = WebInspector.linkifyStringAsFragment(String(b));

if (currentStyle) {

- var wrapper = createElement('span');

+ var wrapper = createElement("span");

wrapper.appendChild(toAppend);

applyCurrentStyle(wrapper);

for (var i = 0; i < wrapper.children.length; ++i)