third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js - Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove yoda disable. fix throw parens Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

index ddd650ea2728074d820baa29bc619a4a0ee76366..fee1c77b053aff47888a753c00fea98c2b1dbf1b 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

@@ -560,7 +560,7 @@ WebInspector.JavaScriptSourceFrame.prototype = {

var endHighlight = anchorBox.highlight.endColumn;

var line = this.textEditor.line(lineNumber);

if (!anchorBox.forSelection) {

- while (startHighlight > 1 && line.charAt(startHighlight - 1) === '.') {

+ while (startHighlight > 1 && line.charAt(startHighlight - 1) === ".") {

var token = this.textEditor.tokenAtTextPosition(lineNumber, startHighlight - 2);

if (!token || !token.type) {

this._popoverHelper.hidePopover();

@@ -749,7 +749,7 @@ WebInspector.JavaScriptSourceFrame.prototype = {

return;

}

- var functionUILocation = WebInspector.debuggerWorkspaceBinding.rawLocationToUILocation(/**@type {!WebInspector.DebuggerModel.Location} */ (callFrame.functionLocation()));

+ var functionUILocation = WebInspector.debuggerWorkspaceBinding.rawLocationToUILocation(/** @type {!WebInspector.DebuggerModel.Location} */ (callFrame.functionLocation()));

var executionUILocation = WebInspector.debuggerWorkspaceBinding.rawLocationToUILocation(callFrame.location());

if (functionUILocation.uiSourceCode !== this.uiSourceCode() || executionUILocation.uiSourceCode !== this.uiSourceCode()) {

this._clearValueWidgets();