third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js - Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js

Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove yoda disable. fix throw parens Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js ('k') | third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js b/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js

index c0e84dd882577ff63375ebc42fe4b24d0988db75..5cf67e76f5d7000a19b2379df4e96d7527b9fb4c 100644

--- a/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js

+++ b/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js

@@ -226,13 +226,13 @@ WebInspector.DOMStorageItemsView.prototype = {

_editingCallback: function(editingNode, columnIdentifier, oldText, newText)

{

var domStorage = this.domStorage;

- if ("key" === columnIdentifier) {

+ if (columnIdentifier === "key") {

if (typeof oldText === "string")

domStorage.removeItem(oldText);

- domStorage.setItem(newText, editingNode.data.value || '');

+ domStorage.setItem(newText, editingNode.data.value || "");

this._removeDupes(editingNode);

} else

- domStorage.setItem(editingNode.data.key || '', newText);

+ domStorage.setItem(editingNode.data.key || "", newText);

/**