third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js - Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove yoda disable. fix throw parens Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sass/SASSProcessor.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js b/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

index 37fb2060dd023584365bc5d1092fc80ae7aad2db..7ed90c311436f380fcfe9738eab0dc6507ecfd5c 100644

--- a/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

+++ b/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

@@ -559,7 +559,7 @@ WebInspector.ScreencastView.prototype = {

* @param {!DOMAgent.Quad} clipQuad

* @param {!DOMAgent.RGBA} fillColor

- _drawOutlinedQuadWithClip: function (quad, clipQuad, fillColor)

+ _drawOutlinedQuadWithClip: function(quad, clipQuad, fillColor)

{

this._context.fillStyle = this._cssColor(fillColor);

this._context.save();

@@ -722,7 +722,7 @@ WebInspector.ScreencastView.prototype = {

this._navigationUrl = this._navigationBar.createChild("input");

this._navigationUrl.type = "text";

- this._navigationUrl.addEventListener('keyup', this._navigationUrlKeyUp.bind(this), true);

+ this._navigationUrl.addEventListener("keyup", this._navigationUrlKeyUp.bind(this), true);

this._navigationProgressBar = new WebInspector.ScreencastView.ProgressTracker(this._navigationBar.createChild("div", "progress"));

@@ -746,7 +746,7 @@ WebInspector.ScreencastView.prototype = {

_navigationUrlKeyUp: function(event)

{

- if (event.keyIdentifier != 'Enter')

+ if (event.keyIdentifier != "Enter")

return;

var url = this._navigationUrl.value;

if (!url)