third_party/WebKit/Source/devtools/front_end/elements/PlatformFontsWidget.js - Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/PlatformFontsWidget.js

Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove yoda disable. fix throw parens Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/PlatformFontsWidget.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/PlatformFontsWidget.js b/third_party/WebKit/Source/devtools/front_end/elements/PlatformFontsWidget.js

index 19c7eb44c4e7451c949ed396976bc2633554088e..f4067cf6ad408b75937ff14a135a06a66d8c47c8 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/PlatformFontsWidget.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/PlatformFontsWidget.js

@@ -90,7 +90,7 @@ WebInspector.PlatformFontsWidget.prototype = {

if (isEmptySection)

return;

- platformFonts.sort(function (a, b) {

+ platformFonts.sort(function(a, b) {

return b.glyphCount - a.glyphCount;

});

for (var i = 0; i < platformFonts.length; ++i) {

@@ -103,7 +103,7 @@ WebInspector.PlatformFontsWidget.prototype = {

fontDelimeterElement.textContent = "\u2014";

var fontOrigin = fontStatElement.createChild("span");

- fontOrigin.textContent = platformFonts[i].isCustomFont? WebInspector.UIString("Network resource") : WebInspector.UIString("Local file");

+ fontOrigin.textContent = platformFonts[i].isCustomFont ? WebInspector.UIString("Network resource") : WebInspector.UIString("Local file");

var fontUsageElement = fontStatElement.createChild("span", "font-usage");

var usage = platformFonts[i].glyphCount;