third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js - Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js

Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove yoda disable. fix throw parens Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHost.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js

index a78f5657114819d9c6f6e4a9e84c8e7721e58397..6479e8ed1424b60b9260d6d577d419a5449adec6 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js

@@ -434,7 +434,7 @@ WebInspector.DeviceModeModel.prototype = {

if (this._type === WebInspector.DeviceModeModel.Type.Device) {

var orientation = this._device.orientationByName(this._mode.orientation);

- var outline = (this._deviceOutlineSetting.get() && Runtime.experiments.isEnabled("deviceFrames"))? orientation.outlineInsets : new Insets(0,0,0,0);

+ var outline = (this._deviceOutlineSetting.get() && Runtime.experiments.isEnabled("deviceFrames")) ? orientation.outlineInsets : new Insets(0,0,0,0);

this._fitScale = this._calculateFitScale(orientation.width, orientation.height);

if (this._device.mobile())

this._appliedUserAgentType = this._device.touch() ? WebInspector.DeviceModeModel.UA.Mobile : WebInspector.DeviceModeModel.UA.MobileNoTouch;

@@ -476,7 +476,7 @@ WebInspector.DeviceModeModel.prototype = {

_calculateFitScale: function(screenWidth, screenHeight)

{

- var scale = Math.min(screenWidth ? this._preferredSize.width / screenWidth: 1, screenHeight ? this._preferredSize.height / screenHeight : 1);

+ var scale = Math.min(screenWidth ? this._preferredSize.width / screenWidth : 1, screenHeight ? this._preferredSize.height / screenHeight : 1);

return Math.min(scale, 1);