Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1880143002: Convert chrome/common to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
dcheng
CC:
chromium-reviews, tapted, cbentzel+watch_chromium.org, Matt Giuca, extensions-reviews_chromium.org, tfarina, rginda+watch_chromium.org, grt+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert chrome/common to std::unique_ptr BUG=554298 Committed: https://crrev.com/8b51c0ab6c7b58cfa186691dcc973527371b2309 Cr-Commit-Position: refs/heads/master@{#386778}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+494 lines, -380 lines) Patch
M chrome/common/auto_start_linux.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/common/child_process_logging_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/common/chrome_content_client_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/chrome_paths_linux.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/common/chrome_paths_mac.mm View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/common/cloud_print/cloud_print_cdd_conversion.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/cloud_print/cloud_print_cdd_conversion.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/cloud_print/cloud_print_helpers.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/cloud_print/cloud_print_helpers.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/common/component_flash_hint_file_linux.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/commands/commands_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/commands/commands_handler.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/common_extension_api_unittest.cc View 1 19 chunks +32 lines, -24 lines 0 comments Download
M chrome/common/extensions/api/extension_action/action_info.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/extension_action/action_info.cc View 11 chunks +17 lines, -16 lines 0 comments Download
M chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/input_ime/input_components_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/networking_private/networking_private_crypto.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/omnibox/omnibox_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/plugins/plugins_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/plugins/plugins_handler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/extensions/api/speech/tts_engine_manifest_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/spellcheck/spellcheck_handler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/extensions/api/storage/storage_schema_manifest_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/system_indicator/system_indicator_handler.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/url_handlers/url_handlers_parser.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/chrome_extensions_client.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/extensions/chrome_extensions_client.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M chrome/common/extensions/chrome_extensions_client_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/extensions/chrome_manifest_url_handlers.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/extensions/command_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_test_util.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/extensions/feature_switch_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc View 9 chunks +13 lines, -12 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/app_icon_color_info.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/app_launch_info.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/automation.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/automation.cc View 13 chunks +23 lines, -20 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/content_scripts_handler.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/copresence_manifest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/extension_action_handler.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/linked_app_icons.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/settings_overrides_handler.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc View 6 chunks +16 lines, -16 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/theme_handler.h View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/theme_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/ui_overrides_handler.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc View 4 chunks +21 lines, -14 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_unittest.cc View 1 7 chunks +13 lines, -12 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/permissions/media_galleries_permission_unittest.cc View 7 chunks +20 lines, -16 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 14 chunks +23 lines, -22 lines 0 comments Download
M chrome/common/extensions/permissions/settings_override_permission_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/common/extensions/value_counter_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/importer/importer_test_registry_overrider_win.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/logging_chrome.cc View 1 5 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/mac/mock_launchd.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/mac/mock_launchd.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/multi_process_lock_unittest.cc View 9 chunks +14 lines, -14 lines 0 comments Download
M chrome/common/net/x509_certificate_model_nss.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/common/net/x509_certificate_model_openssl.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/partial_circular_buffer_unittest.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/common/pepper_permission_util_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/safe_browsing/binary_feature_extractor.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/safe_browsing/binary_feature_extractor_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/safe_browsing/mach_o_image_reader_mac.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/safe_browsing/pe_image_reader_win.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/safe_browsing/pe_image_reader_win.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/safe_browsing/zip_analyzer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/service_process_util.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/service_process_util.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/common/service_process_util_linux.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/service_process_util_mac.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/service_process_util_posix.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/common/service_process_util_posix.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/service_process_util_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/common/service_process_util_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/variations/variations_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
4 years, 8 months ago (2016-04-12 14:57:03 UTC) #2
dcheng
lgtm
4 years, 8 months ago (2016-04-12 18:41:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880143002/20001
4 years, 8 months ago (2016-04-12 18:43:59 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 19:48:28 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 19:50:23 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/8b51c0ab6c7b58cfa186691dcc973527371b2309
Cr-Commit-Position: refs/heads/master@{#386778}

Powered by Google App Engine
This is Rietveld 408576698