OLD | NEW |
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h" | 5 #include <memory> |
6 | 6 |
7 #include "base/command_line.h" | 7 #include "base/command_line.h" |
8 #include "base/memory/scoped_ptr.h" | |
9 #include "base/values.h" | 8 #include "base/values.h" |
10 #include "chrome/common/extensions/features/feature_channel.h" | 9 #include "chrome/common/extensions/features/feature_channel.h" |
| 10 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h" |
11 #include "components/version_info/version_info.h" | 11 #include "components/version_info/version_info.h" |
12 #include "extensions/common/constants.h" | 12 #include "extensions/common/constants.h" |
13 #include "extensions/common/error_utils.h" | 13 #include "extensions/common/error_utils.h" |
14 #include "extensions/common/extension.h" | 14 #include "extensions/common/extension.h" |
15 #include "extensions/common/manifest_constants.h" | 15 #include "extensions/common/manifest_constants.h" |
16 #include "extensions/common/manifest_handlers/background_info.h" | 16 #include "extensions/common/manifest_handlers/background_info.h" |
17 #include "testing/gtest/include/gtest/gtest.h" | 17 #include "testing/gtest/include/gtest/gtest.h" |
18 | 18 |
19 namespace extensions { | 19 namespace extensions { |
20 | 20 |
21 namespace errors = manifest_errors; | 21 namespace errors = manifest_errors; |
22 namespace keys = manifest_keys; | 22 namespace keys = manifest_keys; |
23 | 23 |
24 class ExtensionManifestBackgroundTest : public ChromeManifestTest { | 24 class ExtensionManifestBackgroundTest : public ChromeManifestTest { |
25 }; | 25 }; |
26 | 26 |
27 TEST_F(ExtensionManifestBackgroundTest, BackgroundPermission) { | 27 TEST_F(ExtensionManifestBackgroundTest, BackgroundPermission) { |
28 LoadAndExpectError("background_permission.json", | 28 LoadAndExpectError("background_permission.json", |
29 errors::kBackgroundPermissionNeeded); | 29 errors::kBackgroundPermissionNeeded); |
30 } | 30 } |
31 | 31 |
32 TEST_F(ExtensionManifestBackgroundTest, BackgroundScripts) { | 32 TEST_F(ExtensionManifestBackgroundTest, BackgroundScripts) { |
33 std::string error; | 33 std::string error; |
34 scoped_ptr<base::DictionaryValue> manifest = | 34 std::unique_ptr<base::DictionaryValue> manifest = |
35 LoadManifest("background_scripts.json", &error); | 35 LoadManifest("background_scripts.json", &error); |
36 ASSERT_TRUE(manifest.get()); | 36 ASSERT_TRUE(manifest.get()); |
37 | 37 |
38 scoped_refptr<Extension> extension( | 38 scoped_refptr<Extension> extension( |
39 LoadAndExpectSuccess(ManifestData(manifest.get(), ""))); | 39 LoadAndExpectSuccess(ManifestData(manifest.get(), ""))); |
40 ASSERT_TRUE(extension.get()); | 40 ASSERT_TRUE(extension.get()); |
41 const std::vector<std::string>& background_scripts = | 41 const std::vector<std::string>& background_scripts = |
42 BackgroundInfo::GetBackgroundScripts(extension.get()); | 42 BackgroundInfo::GetBackgroundScripts(extension.get()); |
43 ASSERT_EQ(2u, background_scripts.size()); | 43 ASSERT_EQ(2u, background_scripts.size()); |
44 EXPECT_EQ("foo.js", background_scripts[0u]); | 44 EXPECT_EQ("foo.js", background_scripts[0u]); |
(...skipping 11 matching lines...) Expand all Loading... |
56 | 56 |
57 TEST_F(ExtensionManifestBackgroundTest, BackgroundPage) { | 57 TEST_F(ExtensionManifestBackgroundTest, BackgroundPage) { |
58 scoped_refptr<Extension> extension( | 58 scoped_refptr<Extension> extension( |
59 LoadAndExpectSuccess("background_page.json")); | 59 LoadAndExpectSuccess("background_page.json")); |
60 ASSERT_TRUE(extension.get()); | 60 ASSERT_TRUE(extension.get()); |
61 EXPECT_EQ("/foo.html", | 61 EXPECT_EQ("/foo.html", |
62 BackgroundInfo::GetBackgroundURL(extension.get()).path()); | 62 BackgroundInfo::GetBackgroundURL(extension.get()).path()); |
63 EXPECT_TRUE(BackgroundInfo::AllowJSAccess(extension.get())); | 63 EXPECT_TRUE(BackgroundInfo::AllowJSAccess(extension.get())); |
64 | 64 |
65 std::string error; | 65 std::string error; |
66 scoped_ptr<base::DictionaryValue> manifest( | 66 std::unique_ptr<base::DictionaryValue> manifest( |
67 LoadManifest("background_page_legacy.json", &error)); | 67 LoadManifest("background_page_legacy.json", &error)); |
68 ASSERT_TRUE(manifest.get()); | 68 ASSERT_TRUE(manifest.get()); |
69 extension = LoadAndExpectSuccess(ManifestData(manifest.get(), "")); | 69 extension = LoadAndExpectSuccess(ManifestData(manifest.get(), "")); |
70 ASSERT_TRUE(extension.get()); | 70 ASSERT_TRUE(extension.get()); |
71 EXPECT_EQ("/foo.html", | 71 EXPECT_EQ("/foo.html", |
72 BackgroundInfo::GetBackgroundURL(extension.get()).path()); | 72 BackgroundInfo::GetBackgroundURL(extension.get()).path()); |
73 | 73 |
74 manifest->SetInteger(keys::kManifestVersion, 2); | 74 manifest->SetInteger(keys::kManifestVersion, 2); |
75 LoadAndExpectWarning( | 75 LoadAndExpectWarning( |
76 ManifestData(manifest.get(), ""), | 76 ManifestData(manifest.get(), ""), |
77 "'background_page' requires manifest version of 1 or lower."); | 77 "'background_page' requires manifest version of 1 or lower."); |
78 } | 78 } |
79 | 79 |
80 TEST_F(ExtensionManifestBackgroundTest, BackgroundAllowNoJsAccess) { | 80 TEST_F(ExtensionManifestBackgroundTest, BackgroundAllowNoJsAccess) { |
81 scoped_refptr<Extension> extension; | 81 scoped_refptr<Extension> extension; |
82 extension = LoadAndExpectSuccess("background_allow_no_js_access.json"); | 82 extension = LoadAndExpectSuccess("background_allow_no_js_access.json"); |
83 ASSERT_TRUE(extension.get()); | 83 ASSERT_TRUE(extension.get()); |
84 EXPECT_FALSE(BackgroundInfo::AllowJSAccess(extension.get())); | 84 EXPECT_FALSE(BackgroundInfo::AllowJSAccess(extension.get())); |
85 | 85 |
86 extension = LoadAndExpectSuccess("background_allow_no_js_access2.json"); | 86 extension = LoadAndExpectSuccess("background_allow_no_js_access2.json"); |
87 ASSERT_TRUE(extension.get()); | 87 ASSERT_TRUE(extension.get()); |
88 EXPECT_FALSE(BackgroundInfo::AllowJSAccess(extension.get())); | 88 EXPECT_FALSE(BackgroundInfo::AllowJSAccess(extension.get())); |
89 } | 89 } |
90 | 90 |
91 TEST_F(ExtensionManifestBackgroundTest, BackgroundPageWebRequest) { | 91 TEST_F(ExtensionManifestBackgroundTest, BackgroundPageWebRequest) { |
92 ScopedCurrentChannel current_channel(version_info::Channel::DEV); | 92 ScopedCurrentChannel current_channel(version_info::Channel::DEV); |
93 | 93 |
94 std::string error; | 94 std::string error; |
95 scoped_ptr<base::DictionaryValue> manifest( | 95 std::unique_ptr<base::DictionaryValue> manifest( |
96 LoadManifest("background_page.json", &error)); | 96 LoadManifest("background_page.json", &error)); |
97 ASSERT_TRUE(manifest.get()); | 97 ASSERT_TRUE(manifest.get()); |
98 manifest->SetBoolean(keys::kBackgroundPersistent, false); | 98 manifest->SetBoolean(keys::kBackgroundPersistent, false); |
99 manifest->SetInteger(keys::kManifestVersion, 2); | 99 manifest->SetInteger(keys::kManifestVersion, 2); |
100 scoped_refptr<Extension> extension( | 100 scoped_refptr<Extension> extension( |
101 LoadAndExpectSuccess(ManifestData(manifest.get(), ""))); | 101 LoadAndExpectSuccess(ManifestData(manifest.get(), ""))); |
102 ASSERT_TRUE(extension.get()); | 102 ASSERT_TRUE(extension.get()); |
103 EXPECT_TRUE(BackgroundInfo::HasLazyBackgroundPage(extension.get())); | 103 EXPECT_TRUE(BackgroundInfo::HasLazyBackgroundPage(extension.get())); |
104 | 104 |
105 base::ListValue* permissions = new base::ListValue(); | 105 base::ListValue* permissions = new base::ListValue(); |
(...skipping 30 matching lines...) Expand all Loading... |
136 std::string error; | 136 std::string error; |
137 std::vector<InstallWarning> warnings; | 137 std::vector<InstallWarning> warnings; |
138 ManifestHandler::ValidateExtension(extension.get(), &error, &warnings); | 138 ManifestHandler::ValidateExtension(extension.get(), &error, &warnings); |
139 // The key 'background.persistent' is not supported for packaged apps. | 139 // The key 'background.persistent' is not supported for packaged apps. |
140 EXPECT_EQ(1U, warnings.size()); | 140 EXPECT_EQ(1U, warnings.size()); |
141 EXPECT_EQ(errors::kBackgroundPersistentInvalidForPlatformApps, | 141 EXPECT_EQ(errors::kBackgroundPersistentInvalidForPlatformApps, |
142 warnings[0].message); | 142 warnings[0].message); |
143 } | 143 } |
144 | 144 |
145 } // namespace extensions | 145 } // namespace extensions |
OLD | NEW |