chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc - Issue 1880143002: Convert chrome/common to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc

Issue 1880143002: Convert chrome/common to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc ('k') | chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc

diff --git a/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc b/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc

index 97e65eaef171c8025bc7391d6d244f911c49b3cf..efa6c7ade34f2d575880b0940f18de0e6f4aad5e 100644

--- a/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc

+++ b/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc

@@ -2,6 +2,7 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include <memory>

#include <utility>

#include "base/macros.h"

@@ -47,7 +48,7 @@ TEST_F(FileBrowserHandlerManifestTest, GetHandlersRequiresPermission) {

.Build())

.Build());

- scoped_ptr<base::DictionaryValue> bad_manifest_value(

+ std::unique_ptr<base::DictionaryValue> bad_manifest_value(

bad_manifest_builder.Build());

// Create a good manifest by extending the bad one with the missing