Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Side by Side Diff: chrome/common/extensions/permissions/settings_override_permission_unittest.cc

Issue 1880143002: Convert chrome/common to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // These tests make sure SettingsOverridePermission values are set correctly. 5 // These tests make sure SettingsOverridePermission values are set correctly.
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <memory>
10
9 #include "base/strings/utf_string_conversions.h" 11 #include "base/strings/utf_string_conversions.h"
10 #include "base/values.h" 12 #include "base/values.h"
11 #include "build/build_config.h" 13 #include "build/build_config.h"
12 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h" 14 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"
13 #include "extensions/common/manifest_constants.h" 15 #include "extensions/common/manifest_constants.h"
14 #include "extensions/common/permissions/permission_message_test_util.h" 16 #include "extensions/common/permissions/permission_message_test_util.h"
15 #include "extensions/common/permissions/permission_set.h" 17 #include "extensions/common/permissions/permission_set.h"
16 #include "extensions/common/permissions/permissions_data.h" 18 #include "extensions/common/permissions/permissions_data.h"
17 #include "extensions/common/permissions/settings_override_permission.h" 19 #include "extensions/common/permissions/settings_override_permission.h"
18 #include "testing/gtest/include/gtest/gtest.h" 20 #include "testing/gtest/include/gtest/gtest.h"
19 21
20 namespace extensions { 22 namespace extensions {
21 23
22 namespace { 24 namespace {
23 25
24 class SettingsOverridePermissionTest : public ChromeManifestTest { 26 class SettingsOverridePermissionTest : public ChromeManifestTest {
25 protected: 27 protected:
26 enum Flags { 28 enum Flags {
27 kHomepage = 1, 29 kHomepage = 1,
28 kStartupPages = 1 << 1, 30 kStartupPages = 1 << 1,
29 kSearchProvider = 1 << 2, 31 kSearchProvider = 1 << 2,
30 }; 32 };
31 33
32 scoped_refptr<Extension> GetPermissionSet(uint32_t flags) { 34 scoped_refptr<Extension> GetPermissionSet(uint32_t flags) {
33 base::DictionaryValue ext_manifest; 35 base::DictionaryValue ext_manifest;
34 ext_manifest.SetString(manifest_keys::kName, "test"); 36 ext_manifest.SetString(manifest_keys::kName, "test");
35 ext_manifest.SetString(manifest_keys::kVersion, "0.1"); 37 ext_manifest.SetString(manifest_keys::kVersion, "0.1");
36 ext_manifest.SetInteger(manifest_keys::kManifestVersion, 2); 38 ext_manifest.SetInteger(manifest_keys::kManifestVersion, 2);
37 39
38 scoped_ptr<base::DictionaryValue> settings_override( 40 std::unique_ptr<base::DictionaryValue> settings_override(
39 new base::DictionaryValue); 41 new base::DictionaryValue);
40 if (flags & kHomepage) 42 if (flags & kHomepage)
41 settings_override->SetString("homepage", "http://www.google.com"); 43 settings_override->SetString("homepage", "http://www.google.com");
42 if (flags & kStartupPages) { 44 if (flags & kStartupPages) {
43 scoped_ptr<base::ListValue> startup_pages(new base::ListValue); 45 std::unique_ptr<base::ListValue> startup_pages(new base::ListValue);
44 startup_pages->AppendString("http://startup.com/startup.html"); 46 startup_pages->AppendString("http://startup.com/startup.html");
45 settings_override->Set("startup_pages", startup_pages.release()); 47 settings_override->Set("startup_pages", startup_pages.release());
46 } 48 }
47 if (flags & kSearchProvider) { 49 if (flags & kSearchProvider) {
48 scoped_ptr<base::DictionaryValue> search_provider( 50 std::unique_ptr<base::DictionaryValue> search_provider(
49 new base::DictionaryValue); 51 new base::DictionaryValue);
50 search_provider->SetString("search_url", "http://google.com/search.html"); 52 search_provider->SetString("search_url", "http://google.com/search.html");
51 search_provider->SetString("name", "test"); 53 search_provider->SetString("name", "test");
52 search_provider->SetString("keyword", "lock"); 54 search_provider->SetString("keyword", "lock");
53 search_provider->SetString("encoding", "UTF-8"); 55 search_provider->SetString("encoding", "UTF-8");
54 search_provider->SetBoolean("is_default", true); 56 search_provider->SetBoolean("is_default", true);
55 search_provider->SetString("favicon_url", 57 search_provider->SetString("favicon_url",
56 "http://wikipedia.org/wiki/Favicon"); 58 "http://wikipedia.org/wiki/Favicon");
57 settings_override->Set("search_provider", search_provider.release()); 59 settings_override->Set("search_provider", search_provider.release());
58 } 60 }
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kHomepage)); 148 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kHomepage));
147 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kSearchProvider)); 149 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kSearchProvider));
148 #endif 150 #endif
149 151
150 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kStartupPages)); 152 EXPECT_FALSE(permission_set.HasAPIPermission(APIPermission::kStartupPages));
151 } 153 }
152 154
153 } // namespace 155 } // namespace
154 156
155 } // namespace extensions 157 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/common/extensions/permissions/permission_set_unittest.cc ('k') | chrome/common/extensions/value_counter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698