chrome/common/extensions/value_counter_unittest.cc - Issue 1880143002: Convert chrome/common to std::unique_ptr

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/value_counter_unittest.cc

Issue 1880143002: Convert chrome/common to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/memory/scoped_ptr.h"	5 #include <memory>

	6

6 #include "base/values.h"	7 #include "base/values.h"

7 #include "extensions/common/value_counter.h"	8 #include "extensions/common/value_counter.h"

8 #include "testing/gtest/include/gtest/gtest.h"	9 #include "testing/gtest/include/gtest/gtest.h"

9	10

10 using ValueCounterTest = testing::Test;	11 using ValueCounterTest = testing::Test;

11	12

12 namespace extensions {	13 namespace extensions {

13	14

14 TEST_F(ValueCounterTest, TestAddingSameValue) {	15 TEST_F(ValueCounterTest, TestAddingSameValue) {

15 ValueCounter vc;	16 ValueCounter vc;

(...skipping 43 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
59 vc.Add(value1);	60 vc.Add(value1);

60 vc.Add(value2);	61 vc.Add(value2);

61 ASSERT_FALSE(vc.is_empty());	62 ASSERT_FALSE(vc.is_empty());

62 vc.Remove(value1);	63 vc.Remove(value1);

63 ASSERT_FALSE(vc.is_empty());	64 ASSERT_FALSE(vc.is_empty());

64 vc.Remove(value2);	65 vc.Remove(value2);

65 ASSERT_TRUE(vc.is_empty());	66 ASSERT_TRUE(vc.is_empty());

66 }	67 }

67	68

68 } // namespace extensions	69 } // namespace extensions

OLD	NEW