chrome/common/extensions/manifest_handlers/settings_overrides_handler.h - Issue 1880143002: Convert chrome/common to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/settings_overrides_handler.h

Issue 1880143002: Convert chrome/common to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/linked_app_icons.cc ('k') | chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/settings_overrides_handler.h

diff --git a/chrome/common/extensions/manifest_handlers/settings_overrides_handler.h b/chrome/common/extensions/manifest_handlers/settings_overrides_handler.h

index 58d8dc68dd71f2c099c85dbed51ca1d289fafd6b..c0adfa3134d12cb63bf2f89b2c5722706c5b5204 100644

--- a/chrome/common/extensions/manifest_handlers/settings_overrides_handler.h

+++ b/chrome/common/extensions/manifest_handlers/settings_overrides_handler.h

@@ -5,6 +5,8 @@

#ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_SETTINGS_OVERRIDES_HANDLER_H_

#define CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_SETTINGS_OVERRIDES_HANDLER_H_

+#include <memory>

#include "base/macros.h"

#include "chrome/common/extensions/api/manifest_types.h"

#include "extensions/common/extension.h"

@@ -29,9 +31,9 @@ struct SettingsOverrides : public Extension::ManifestData {

static const SettingsOverrides* Get(const Extension* extension);

- scoped_ptr<api::manifest_types::ChromeSettingsOverrides::Search_provider>

+ std::unique_ptr<api::manifest_types::ChromeSettingsOverrides::Search_provider>

search_engine;

- scoped_ptr<GURL> homepage;

+ std::unique_ptr<GURL> homepage;

std::vector<GURL> startup_pages;

private: