chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc - Issue 1880143002: Convert chrome/common to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

Issue 1880143002: Convert chrome/common to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc ('k') | chrome/common/extensions/manifest_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

index 110484dc8cdf27d5852861a3ab44d8c12dc14147..5a8581b48c1ef9835f32832e4886fa3b6f8c3e4f 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

@@ -2,9 +2,9 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include <memory>

#include <utility>

-#include "base/memory/scoped_ptr.h"

#include "base/values.h"

#include "chrome/common/extensions/manifest_handlers/app_launch_info.h"

#include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"

@@ -27,7 +27,7 @@ TEST_F(ValidAppManifestTest, ValidApp) {

TEST_F(ValidAppManifestTest, AllowUnrecognizedPermissions) {

std::string error;

- scoped_ptr<base::DictionaryValue> manifest(

+ std::unique_ptr<base::DictionaryValue> manifest(

LoadManifest("valid_app.json", &error));

base::ListValue* permissions = NULL;

ASSERT_TRUE(manifest->GetList("permissions", &permissions));