chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc - Issue 1880143002: Convert chrome/common to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc

Issue 1880143002: Convert chrome/common to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc

index 854c2df6030ac14923351a0ccefa184f1a8e7bcd..433b62e888d61c6fd95a684c1fff8f1327c53f99 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc

@@ -2,25 +2,26 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"

+#include <memory>

+#include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"

#include "extensions/common/manifest_constants.h"

-#include "testing/gtest/include/gtest/gtest.h"

#include "testing/gmock/include/gmock/gmock.h"

+#include "testing/gtest/include/gtest/gtest.h"

using extensions::Extension;

namespace errors = extensions::manifest_errors;

TEST_F(ChromeManifestTest, ManifestVersionError) {

- scoped_ptr<base::DictionaryValue> manifest1(new base::DictionaryValue());

+ std::unique_ptr<base::DictionaryValue> manifest1(new base::DictionaryValue());

manifest1->SetString("name", "Miles");

manifest1->SetString("version", "0.55");

- scoped_ptr<base::DictionaryValue> manifest2(manifest1->DeepCopy());

+ std::unique_ptr<base::DictionaryValue> manifest2(manifest1->DeepCopy());

manifest2->SetInteger("manifest_version", 1);

- scoped_ptr<base::DictionaryValue> manifest3(manifest1->DeepCopy());

+ std::unique_ptr<base::DictionaryValue> manifest3(manifest1->DeepCopy());

manifest3->SetInteger("manifest_version", 2);

struct {