Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1850543003: Revert of rename sk_gpu_test::GLContext to sk_gpu_test::GLTestContext (Closed)

Created:
4 years, 8 months ago by bsalomon
Modified:
4 years, 8 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@move
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of rename sk_gpu_test::GLContext to sk_gpu_test::GLTestContext (patchset #5 id:80001 of https://codereview.chromium.org/1849463002/ ) Reason for revert: breaking bots Original issue's description: > rename sk_gpu_test::GLContext to sk_gpu_test::GLTestContext > > rename subclasses > > Fix up the EGL native GLTestContext > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1849463002 > > TBR=jvanverth@google.com > > Committed: https://skia.googlesource.com/skia/+/4c7f0a16312c374eba4e8d5d46435ce9eb0b9971 TBR=jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/3e4616ff10fad7ee7dae48f465223b4591ec8ffd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4350 lines, -4356 lines) Patch
M bench/nanobench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M dm/DM.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/EGLImageTest.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M tests/RectangleTextureTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/Test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/TestTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/TextureStorageAllocator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/VisualBench/VisualBench.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/VisualBench/VisualBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/VisualBench/VisualStreamTimingModule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/gpu/GrContextFactory.h View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/gpu/GrContextFactory.cpp View 2 chunks +16 lines, -16 lines 0 comments Download
A tools/gpu/gl/GLContext.h View 1 chunk +141 lines, -0 lines 0 comments Download
A tools/gpu/gl/GLContext.cpp View 1 chunk +188 lines, -0 lines 0 comments Download
D tools/gpu/gl/GLTestContext.h View 1 chunk +0 lines, -141 lines 0 comments Download
D tools/gpu/gl/GLTestContext.cpp View 1 chunk +0 lines, -188 lines 0 comments Download
A tools/gpu/gl/angle/GLContext_angle.h View 1 chunk +30 lines, -0 lines 0 comments Download
A tools/gpu/gl/angle/GLContext_angle.cpp View 1 chunk +320 lines, -0 lines 0 comments Download
D tools/gpu/gl/angle/GLTestContext_angle.h View 1 chunk +0 lines, -30 lines 0 comments Download
D tools/gpu/gl/angle/GLTestContext_angle.cpp View 1 chunk +0 lines, -320 lines 0 comments Download
A tools/gpu/gl/command_buffer/GLContext_command_buffer.h View 1 chunk +68 lines, -0 lines 0 comments Download
A tools/gpu/gl/command_buffer/GLContext_command_buffer.cpp View 1 chunk +345 lines, -0 lines 0 comments Download
D tools/gpu/gl/command_buffer/GLTestContext_command_buffer.h View 1 chunk +0 lines, -68 lines 0 comments Download
D tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp View 1 chunk +0 lines, -345 lines 0 comments Download
A tools/gpu/gl/debug/DebugGLContext.h View 1 chunk +17 lines, -0 lines 0 comments Download
A tools/gpu/gl/debug/DebugGLContext.cpp View 1 chunk +1256 lines, -0 lines 0 comments Download
D tools/gpu/gl/debug/DebugGLTestContext.h View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/gpu/gl/debug/DebugGLTestContext.cpp View 1 chunk +0 lines, -1256 lines 0 comments Download
A tools/gpu/gl/egl/CreatePlatformGLContext_egl.cpp View 1 chunk +337 lines, -0 lines 0 comments Download
D tools/gpu/gl/egl/CreatePlatformGLTestContext_egl.cpp View 1 chunk +0 lines, -339 lines 0 comments Download
A tools/gpu/gl/glx/CreatePlatformGLContext_glx.cpp View 1 chunk +346 lines, -0 lines 0 comments Download
D tools/gpu/gl/glx/CreatePlatformGLTestContext_glx.cpp View 1 chunk +0 lines, -347 lines 0 comments Download
A tools/gpu/gl/iOS/CreatePlatformGLContext_iOS.mm View 1 chunk +108 lines, -0 lines 0 comments Download
D tools/gpu/gl/iOS/CreatePlatformGLTestContext_iOS.mm View 1 chunk +0 lines, -109 lines 0 comments Download
A tools/gpu/gl/mac/CreatePlatformGLContext_mac.cpp View 1 chunk +128 lines, -0 lines 0 comments Download
D tools/gpu/gl/mac/CreatePlatformGLTestContext_mac.cpp View 1 chunk +0 lines, -129 lines 0 comments Download
A tools/gpu/gl/mesa/GLContext_mesa.h View 1 chunk +17 lines, -0 lines 0 comments Download
A tools/gpu/gl/mesa/GLContext_mesa.cpp View 1 chunk +151 lines, -0 lines 0 comments Download
D tools/gpu/gl/mesa/GLTestContext_mesa.h View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/gpu/gl/mesa/GLTestContext_mesa.cpp View 1 chunk +0 lines, -151 lines 0 comments Download
A tools/gpu/gl/null/NullGLContext.h View 1 chunk +17 lines, -0 lines 0 comments Download
A tools/gpu/gl/null/NullGLContext.cpp View 1 chunk +630 lines, -0 lines 0 comments Download
D tools/gpu/gl/null/NullGLTestContext.h View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/gpu/gl/null/NullGLTestContext.cpp View 1 chunk +0 lines, -630 lines 0 comments Download
A tools/gpu/gl/win/CreatePlatformGLContext_win.cpp View 1 chunk +204 lines, -0 lines 0 comments Download
D tools/gpu/gl/win/CreatePlatformGLTestContext_win.cpp View 1 chunk +0 lines, -205 lines 0 comments Download
M tools/kilobench/kilobench.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M tools/skiaserve/Request.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
bsalomon
Created Revert of rename sk_gpu_test::GLContext to sk_gpu_test::GLTestContext
4 years, 8 months ago (2016-03-31 17:22:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850543003/1
4 years, 8 months ago (2016-03-31 17:22:14 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 17:22:45 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3e4616ff10fad7ee7dae48f465223b4591ec8ffd

Powered by Google App Engine
This is Rietveld 408576698