Simplify references to command line flags.

Simplify references to command line flags.

This CL removes all indirect pointer chasing to get the values of
command line flags. Since we are only using 1 copy of ClFlags, this CL
introduces a static field Flags to hold the defined command line flags
(it was previously a static field of GlobalContext).

For those few contexts where one must change CL flags due to context
(such as testsing and running in the browser), use ClFlags::Flags.

In the remainder of the cases, the code uses getFlags() which returns
a constant reference to ClFlags::Flags, allowing access to the get
accessors.

BUG=None
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=d46999474d2b4a388e1d8a7c71f06cd4cec51bfc

[Karl, 2016-04-01 18:01:20]

Description was changed from

==========
Simplify referneces to command line flags.

This CL removes all indirect pointer chasing to get the values of
command line flags. Since we are only using 1 copy of ClFlags, this CL
introduces a static field Flags to hold the defined command line flags
(it was previously a static field of GlobalContext).

For those few contexts where one must change CL flags due to context
(such as testsing and running in the browser), use ClFlags::Flags.

In the remainder of the cases, the code uses getFlags() which returns
a constant reference to ClFlags::Flags, allowing access to the get
accessors.

BUG=None
==========

to

==========
Simplify referneces to command line flags.

This CL removes all indirect pointer chasing to get the values of
command line flags. Since we are only using 1 copy of ClFlags, this CL
introduces a static field Flags to hold the defined command line flags
(it was previously a static field of GlobalContext).

For those few contexts where one must change CL flags due to context
(such as testsing and running in the browser), use ClFlags::Flags.

In the remainder of the cases, the code uses getFlags() which returns
a constant reference to ClFlags::Flags, allowing access to the get
accessors.

BUG=None
==========

[Karl, 2016-04-01 18:01:20]

kschimpf@google.com changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, seh@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2016-04-01 22:11:19]

Description was changed from

==========
Simplify referneces to command line flags.

This CL removes all indirect pointer chasing to get the values of
command line flags. Since we are only using 1 copy of ClFlags, this CL
introduces a static field Flags to hold the defined command line flags
(it was previously a static field of GlobalContext).

For those few contexts where one must change CL flags due to context
(such as testsing and running in the browser), use ClFlags::Flags.

In the remainder of the cases, the code uses getFlags() which returns
a constant reference to ClFlags::Flags, allowing access to the get
accessors.

BUG=None
==========

to

==========
Simplify references to command line flags.

This CL removes all indirect pointer chasing to get the values of
command line flags. Since we are only using 1 copy of ClFlags, this CL
introduces a static field Flags to hold the defined command line flags
(it was previously a static field of GlobalContext).

For those few contexts where one must change CL flags due to context
(such as testsing and running in the browser), use ClFlags::Flags.

In the remainder of the cases, the code uses getFlags() which returns
a constant reference to ClFlags::Flags, allowing access to the get
accessors.

BUG=None
==========

[Jim Stichnoth, 2016-04-01 23:36:59]

lgtm

https://codereview.chromium.org/1848303003/diff/40001/src/IceBrowserCompileSe...
File src/IceBrowserCompileServer.cpp (right):

https://codereview.chromium.org/1848303003/diff/40001/src/IceBrowserCompileSe...
src/IceBrowserCompileServer.cpp:174: ClFlags::Flags.setBuildOnRead(true);
I think you can and should remove this because the default is already true.

Maybe for another CL, the InputFileFormat default should be changed to
PNaClFormat, and the following line can also be removed.

https://codereview.chromium.org/1848303003/diff/40001/src/IceFixups.h
File src/IceFixups.h (right):

https://codereview.chromium.org/1848303003/diff/40001/src/IceFixups.h#newcode19
src/IceFixups.h:19: #include "IceClFlags.h"
alphabetize this if possible

[Jim Stichnoth, 2016-04-01 23:54:22]

stichnot@chromium.org changed reviewers:
+ sehr@chromium.org
- seh@chromium.org

[Jim Stichnoth, 2016-04-01 23:54:38]

-seh
+sehr

[Karl, 2016-04-02 16:55:35]

Description was changed from

==========
Simplify references to command line flags.

This CL removes all indirect pointer chasing to get the values of
command line flags. Since we are only using 1 copy of ClFlags, this CL
introduces a static field Flags to hold the defined command line flags
(it was previously a static field of GlobalContext).

For those few contexts where one must change CL flags due to context
(such as testsing and running in the browser), use ClFlags::Flags.

In the remainder of the cases, the code uses getFlags() which returns
a constant reference to ClFlags::Flags, allowing access to the get
accessors.

BUG=None
==========

to

==========
Simplify references to command line flags.

This CL removes all indirect pointer chasing to get the values of
command line flags. Since we are only using 1 copy of ClFlags, this CL
introduces a static field Flags to hold the defined command line flags
(it was previously a static field of GlobalContext).

For those few contexts where one must change CL flags due to context
(such as testsing and running in the browser), use ClFlags::Flags.

In the remainder of the cases, the code uses getFlags() which returns
a constant reference to ClFlags::Flags, allowing access to the get
accessors.

BUG=None
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Karl, 2016-04-02 16:55:37]

Committed patchset #4 (id:60001) manually as
d46999474d2b4a388e1d8a7c71f06cd4cec51bfc (presubmit successful).

[Karl, 2016-04-02 16:55:56]

https://codereview.chromium.org/1848303003/diff/40001/src/IceBrowserCompileSe...
File src/IceBrowserCompileServer.cpp (right):

https://codereview.chromium.org/1848303003/diff/40001/src/IceBrowserCompileSe...
src/IceBrowserCompileServer.cpp:174: ClFlags::Flags.setBuildOnRead(true);
On 2016/04/01 23:36:58, stichnot wrote:
> I think you can and should remove this because the default is already true.
> 
> Maybe for another CL, the InputFileFormat default should be changed to
> PNaClFormat, and the following line can also be removed.

Removed BuildOnRead, left InputFileFormat for another CL.

https://codereview.chromium.org/1848303003/diff/40001/src/IceFixups.h
File src/IceFixups.h (right):

https://codereview.chromium.org/1848303003/diff/40001/src/IceFixups.h#newcode19
src/IceFixups.h:19: #include "IceClFlags.h"
On 2016/04/01 23:36:58, stichnot wrote:
> alphabetize this if possible

Done.