Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: src/IceGlobalInits.h

Issue 1848303003: Simplify references to command line flags. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nits. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceGlobalContext.cpp ('k') | src/IceInstARM32.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceGlobalInits.h
diff --git a/src/IceGlobalInits.h b/src/IceGlobalInits.h
index 862cc1dd5c77be81b64a666aac63b0e0f8fc3b0f..378d5d793696dbe8bc59ebce763a388a48c65b23 100644
--- a/src/IceGlobalInits.h
+++ b/src/IceGlobalInits.h
@@ -109,14 +109,14 @@ protected:
/// Returns true if linkage is defined correctly for the global declaration,
/// based on default rules.
- bool verifyLinkageDefault(const GlobalContext *Ctx) const {
+ bool verifyLinkageDefault() const {
switch (Linkage) {
default:
return false;
case llvm::GlobalValue::InternalLinkage:
return true;
case llvm::GlobalValue::ExternalLinkage:
- return Ctx->getFlags().getAllowExternDefinedSymbols();
+ return getFlags().getAllowExternDefinedSymbols();
}
}
@@ -160,7 +160,7 @@ public:
return Linkage == llvm::GlobalValue::ExternalLinkage;
}
}
- return verifyLinkageDefault(Ctx);
+ return verifyLinkageDefault();
}
/// Validates that the type signature of the function is correct. Returns true
@@ -461,13 +461,13 @@ public:
virtual void dump(Ostream &Stream) const override;
/// Returns true if linkage is correct for the variable declaration.
- bool verifyLinkageCorrect(const GlobalContext *Ctx) const {
+ bool verifyLinkageCorrect() const {
if (getName().hasStdString()) {
if (isPNaClABIExternalName(getName().toString())) {
return Linkage == llvm::GlobalValue::ExternalLinkage;
}
}
- return verifyLinkageDefault(Ctx);
+ return verifyLinkageDefault();
}
static bool classof(const GlobalDeclaration *Addr) {
« no previous file with comments | « src/IceGlobalContext.cpp ('k') | src/IceInstARM32.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698