Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1385)

Unified Diff: src/IceCompiler.cpp

Issue 1848303003: Simplify references to command line flags. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nits. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceCompileServer.cpp ('k') | src/IceConverter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceCompiler.cpp
diff --git a/src/IceCompiler.cpp b/src/IceCompiler.cpp
index 7a426fc28de566adac7e312d331106da5175663f..3120beaa0d69187ae57bc2f0a219db7d7c944091 100644
--- a/src/IceCompiler.cpp
+++ b/src/IceCompiler.cpp
@@ -61,7 +61,7 @@ void Compiler::run(const Ice::ClFlags &Flags, GlobalContext &Ctx,
// The Minimal build (specifically, when dump()/emit() are not implemented)
// allows only --filetype=obj. Check here to avoid cryptic error messages
// downstream.
- if (!BuildDefs::dump() && Ctx.getFlags().getOutFileType() != FT_Elf) {
+ if (!BuildDefs::dump() && getFlags().getOutFileType() != FT_Elf) {
Ctx.getStrError()
<< "Error: only --filetype=obj is supported in this build.\n";
Ctx.getErrorStatus()->assign(EC_Args);
@@ -130,17 +130,17 @@ void Compiler::run(const Ice::ClFlags &Flags, GlobalContext &Ctx,
Ctx.lowerConstants();
Ctx.lowerJumpTables();
- if (Ctx.getFlags().getOutFileType() == FT_Elf) {
+ if (getFlags().getOutFileType() == FT_Elf) {
TimerMarker T1(Ice::TimerStack::TT_emitAsm, &Ctx);
Ctx.getObjectWriter()->setUndefinedSyms(Ctx.getConstantExternSyms());
Ctx.getObjectWriter()->writeNonUserSections();
}
}
- if (Ctx.getFlags().getSubzeroTimingEnabled())
+ if (getFlags().getSubzeroTimingEnabled())
Ctx.dumpTimers();
- if (Ctx.getFlags().getTimeEachFunction()) {
+ if (getFlags().getTimeEachFunction()) {
constexpr bool NoDumpCumulative = false;
Ctx.dumpTimers(GlobalContext::TSK_Funcs, NoDumpCumulative);
}
« no previous file with comments | « src/IceCompileServer.cpp ('k') | src/IceConverter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698