src/IceFixups.cpp - Issue 1848303003: Simplify references to command line flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceFixups.cpp

Issue 1848303003: Simplify references to command line flags. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix nits. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceFixups.cpp

diff --git a/src/IceFixups.cpp b/src/IceFixups.cpp

index 3d3b1b437c7dbb405c390a4ec668316ad2e37629..b7e8031bddf771f6552bacb37fbf67a8ab2b10f1 100644

--- a/src/IceFixups.cpp

+++ b/src/IceFixups.cpp

@@ -58,8 +58,7 @@ size_t AssemblerFixup::emit(GlobalContext *Ctx, const Assembler &Asm) const {

Str << Symbol;

assert(!ValueIsSymbol);

if (const auto *CR = llvm::dyn_cast<ConstantRelocatable>(ConstValue)) {

- if (!Asm.fixupIsPCRel(kind()) &&

- GlobalContext::getFlags().getUseNonsfi() &&

+ if (!Asm.fixupIsPCRel(kind()) && getFlags().getUseNonsfi() &&

CR->getName().toString() != GlobalOffsetTable) {

Str << "@GOTOFF";

}

« no previous file with comments | « src/IceFixups.h ('k') | src/IceGlobalContext.h » ('j') | no next file with comments »