Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: src/IceBrowserCompileServer.h

Issue 1848303003: Simplify references to command line flags. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nits. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/IceAssemblerARM32.cpp ('k') | src/IceBrowserCompileServer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 //===- subzero/src/IceBrowserCompileServer.h - Browser server ---*- C++ -*-===// 1 //===- subzero/src/IceBrowserCompileServer.h - Browser server ---*- C++ -*-===//
2 // 2 //
3 // The Subzero Code Generator 3 // The Subzero Code Generator
4 // 4 //
5 // This file is distributed under the University of Illinois Open Source 5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details. 6 // License. See LICENSE.TXT for details.
7 // 7 //
8 //===----------------------------------------------------------------------===// 8 //===----------------------------------------------------------------------===//
9 /// 9 ///
10 /// \file 10 /// \file
(...skipping 23 matching lines...) Expand all
34 /// version, this version gets compile requests over IPC. Each compile request 34 /// version, this version gets compile requests over IPC. Each compile request
35 /// will have a slimmed down version of argc, argv while other flags are set to 35 /// will have a slimmed down version of argc, argv while other flags are set to
36 /// defaults that make sense in the browser case. The output file is specified 36 /// defaults that make sense in the browser case. The output file is specified
37 /// via a posix FD, and input bytes are pushed to the server. 37 /// via a posix FD, and input bytes are pushed to the server.
38 class BrowserCompileServer : public CompileServer { 38 class BrowserCompileServer : public CompileServer {
39 BrowserCompileServer(const BrowserCompileServer &) = delete; 39 BrowserCompileServer(const BrowserCompileServer &) = delete;
40 BrowserCompileServer &operator=(const BrowserCompileServer &) = delete; 40 BrowserCompileServer &operator=(const BrowserCompileServer &) = delete;
41 class StringStream; 41 class StringStream;
42 42
43 public: 43 public:
44 BrowserCompileServer() : Flags(&GlobalContext::Flags), HadError(false) {} 44 BrowserCompileServer() : HadError(false) {}
45 45
46 ~BrowserCompileServer() final; 46 ~BrowserCompileServer() final;
47 47
48 void run() final; 48 void run() final;
49 49
50 ErrorCode &getErrorCode() final; 50 ErrorCode &getErrorCode() final;
51 51
52 /// Parse and set up the flags for compile jobs. 52 /// Parse and set up the flags for compile jobs.
53 void getParsedFlags(uint32_t NumThreads, int argc, char **argv); 53 void getParsedFlags(uint32_t NumThreads, int argc, char **argv);
54 54
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 /// the state. 94 /// the state.
95 std::unique_ptr<GlobalContext> Ctx; 95 std::unique_ptr<GlobalContext> Ctx;
96 /// A borrowed reference to the current InputStream. The compiler owns the 96 /// A borrowed reference to the current InputStream. The compiler owns the
97 /// actual reference so the server must be careful not to access after the 97 /// actual reference so the server must be careful not to access after the
98 /// compiler is done. 98 /// compiler is done.
99 llvm::QueueStreamer *InputStream = nullptr; 99 llvm::QueueStreamer *InputStream = nullptr;
100 std::unique_ptr<Ostream> LogStream; 100 std::unique_ptr<Ostream> LogStream;
101 std::unique_ptr<llvm::raw_fd_ostream> EmitStream; 101 std::unique_ptr<llvm::raw_fd_ostream> EmitStream;
102 std::unique_ptr<StringStream> ErrorStream; 102 std::unique_ptr<StringStream> ErrorStream;
103 std::unique_ptr<ELFStreamer> ELFStream; 103 std::unique_ptr<ELFStreamer> ELFStream;
104 ClFlags *Flags;
105 std::thread CompileThread; 104 std::thread CompileThread;
106 std::atomic<bool> HadError; 105 std::atomic<bool> HadError;
107 }; 106 };
108 107
109 } // end of namespace Ice 108 } // end of namespace Ice
110 109
111 #endif // SUBZERO_SRC_ICEBROWSERCOMPILESERVER_H 110 #endif // SUBZERO_SRC_ICEBROWSERCOMPILESERVER_H
OLDNEW
« no previous file with comments | « src/IceAssemblerARM32.cpp ('k') | src/IceBrowserCompileServer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698