Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183893010: DevTools: extract TimelineModel.Record from TimelinePresentationModel.Record. (Closed)

Created:
6 years, 9 months ago by pfeldman
Modified:
6 years, 9 months ago
Reviewers:
caseq, loislo
CC:
blink-reviews, shans, apavlov+blink_chromium.org, rjwright, Steve Block, dino_apple.com, caseq+blink_chromium.org, aandrey+blink_chromium.org, alancutter (OOO until 2018), pfeldman+blink_chromium.org, yurys+blink_chromium.org, dstockwell, Timothy Loh, devtools-reviews_chromium.org, Eric Willigers, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, alph+blink_chromium.org, vsevik+blink_chromium.org, Mike Lawther (Google)
Visibility:
Public.

Description

DevTools: extract TimelineModel.Record from TimelinePresentationModel.Record. This change splits the model and presentation parts of the timeline recod. Now model + all views operates modal records. TimelineView wraps them in presentation records. Next step is to move filters out of presentation model and make it private to the TimelineView. R=caseq@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168290

Patch Set 1 : #

Total comments: 12

Patch Set 2 : Review comments addressed. #

Patch Set 3 : For landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+944 lines, -756 lines) Patch
M LayoutTests/http/tests/inspector/timeline-test.js View 4 chunks +34 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/inspector/websocket/timeline-websocket-event.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/timeline-dfs.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/timeline-dfs-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-animation-frame.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-coalescing.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-coalescing-expected.txt View 2 chunks +6 lines, -5 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-compatibility.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-dom-content-loaded-event.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-filtering.html View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-load.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-load-event.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-mark-timeline.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-network-resource.html View 2 chunks +1 line, -2 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-receive-response-event.html View 1 chunk +15 lines, -14 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-time.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-time-stamp.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-timer.html View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/CountersGraph.js View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/devtools/front_end/MemoryStatistics.js View 6 chunks +10 lines, -12 lines 0 comments Download
M Source/devtools/front_end/TimelineEventOverview.js View 2 chunks +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/TimelineFlameChart.js View 6 chunks +12 lines, -9 lines 0 comments Download
M Source/devtools/front_end/TimelineFrameModel.js View 9 chunks +11 lines, -11 lines 0 comments Download
M Source/devtools/front_end/TimelineMemoryOverview.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/TimelineModel.js View 1 12 chunks +508 lines, -22 lines 0 comments Download
M Source/devtools/front_end/TimelineOverviewPane.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/TimelinePanel.js View 1 15 chunks +26 lines, -32 lines 0 comments Download
M Source/devtools/front_end/TimelinePresentationModel.js View 1 18 chunks +147 lines, -475 lines 0 comments Download
M Source/devtools/front_end/TimelineUIUtils.js View 1 2 14 chunks +39 lines, -32 lines 0 comments Download
M Source/devtools/front_end/TimelineView.js View 1 30 chunks +107 lines, -102 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pfeldman
6 years, 9 months ago (2014-03-02 09:17:26 UTC) #1
caseq
lgtm https://codereview.chromium.org/183893010/diff/20001/Source/devtools/front_end/TimelineModel.js File Source/devtools/front_end/TimelineModel.js (right): https://codereview.chromium.org/183893010/diff/20001/Source/devtools/front_end/TimelineModel.js#newcode125 Source/devtools/front_end/TimelineModel.js:125: WebInspector.TimelineModel.forAllRecords = function(recordsArray, preOrderCallback, postOrderCallback) This can be ...
6 years, 9 months ago (2014-03-03 09:08:32 UTC) #2
pfeldman
https://codereview.chromium.org/183893010/diff/20001/Source/devtools/front_end/TimelineModel.js File Source/devtools/front_end/TimelineModel.js (right): https://codereview.chromium.org/183893010/diff/20001/Source/devtools/front_end/TimelineModel.js#newcode125 Source/devtools/front_end/TimelineModel.js:125: WebInspector.TimelineModel.forAllRecords = function(recordsArray, preOrderCallback, postOrderCallback) On 2014/03/03 09:08:32, caseq ...
6 years, 9 months ago (2014-03-03 10:03:44 UTC) #3
pfeldman
6 years, 9 months ago (2014-03-03 10:08:08 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as r168290 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698