Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1612)

Unified Diff: Source/devtools/front_end/TimelineMemoryOverview.js

Issue 183893010: DevTools: extract TimelineModel.Record from TimelinePresentationModel.Record. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: For landing Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/TimelineFrameModel.js ('k') | Source/devtools/front_end/TimelineModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/TimelineMemoryOverview.js
diff --git a/Source/devtools/front_end/TimelineMemoryOverview.js b/Source/devtools/front_end/TimelineMemoryOverview.js
index 1fefdf251e3983938a8efd29143b459eb8171848..6f163a4cf524406551c905f08a2bc0c4085ef57f 100644
--- a/Source/devtools/front_end/TimelineMemoryOverview.js
+++ b/Source/devtools/front_end/TimelineMemoryOverview.js
@@ -53,7 +53,7 @@ WebInspector.TimelineMemoryOverview.prototype = {
{
this.resetCanvas();
- var records = this._model.records;
+ var records = this._model.records();
if (!records.length) {
this.resetHeapSizeLabels();
return;
@@ -64,7 +64,7 @@ WebInspector.TimelineMemoryOverview.prototype = {
var minUsedHeapSize = 100000000000;
var minTime = this._model.minimumRecordTime();
var maxTime = this._model.maximumRecordTime();
- WebInspector.TimelinePresentationModel.forAllRecords(records, function(r) {
+ this._model.forAllRecords(function(r) {
if (!r.counters || !r.counters.jsHeapSizeUsed)
return;
maxUsedHeapSize = Math.max(maxUsedHeapSize, r.counters.jsHeapSizeUsed);
@@ -78,7 +78,7 @@ WebInspector.TimelineMemoryOverview.prototype = {
var yFactor = height / Math.max(maxUsedHeapSize - minUsedHeapSize, 1);
var histogram = new Array(width);
- WebInspector.TimelinePresentationModel.forAllRecords(records, function(r) {
+ this._model.forAllRecords(function(r) {
if (!r.counters || !r.counters.jsHeapSizeUsed)
return;
var x = Math.round((r.endTime - minTime) * xFactor);
« no previous file with comments | « Source/devtools/front_end/TimelineFrameModel.js ('k') | Source/devtools/front_end/TimelineModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698