Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: LayoutTests/inspector/timeline/timeline-receive-response-event.html

Issue 183893010: DevTools: extract TimelineModel.Record from TimelinePresentationModel.Record. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: For landing Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/inspector/timeline/timeline-receive-response-event.html
diff --git a/LayoutTests/inspector/timeline/timeline-receive-response-event.html b/LayoutTests/inspector/timeline/timeline-receive-response-event.html
index 3daf7293555b13e0e00323dc65cb7001ab591fdd..11c327963bfc3cee438df9a37f6d98391aba87dc 100644
--- a/LayoutTests/inspector/timeline/timeline-receive-response-event.html
+++ b/LayoutTests/inspector/timeline/timeline-receive-response-event.html
@@ -36,24 +36,25 @@ function test()
function step3()
{
- function dumpFormattedRecord(record, prefix)
+ function dumpFormattedRecord(presentationRecord, prefix)
{
- prefix = prefix || "";
- // Here and below: pretend coalesced record are just not there, as coalescation is time dependent and, hence, not stable.
- if (!record.coalesced && record.type !== "GCEvent")
- InspectorTest.addResult(prefix + record.type);
- // Ignore stray paint & rendering events for better stability.
- if (record.category.name !== "loading" && record.category.name !== "scripting")
- return;
- if (record._children) {
- var childPrefix = prefix + (record.coalesced ? "" : " ");
- for (var i = 0; i < record._children.length; ++i)
- dumpFormattedRecord(record._children[i], childPrefix);
- }
+ var record = presentationRecord.record();
+ prefix = prefix || "";
+ // Here and below: pretend coalesced record are just not there, as coalescation is time dependent and, hence, not stable.
+ if (!presentationRecord.coalesced() && record.type !== "GCEvent")
+ InspectorTest.addResult(prefix + record.type);
+ // Ignore stray paint & rendering events for better stability.
+ if (record.category.name !== "loading" && record.category.name !== "scripting")
+ return;
+ if (presentationRecord.presentationChildren()) {
+ var childPrefix = prefix + (presentationRecord.coalesced() ? "" : " ");
+ for (var i = 0; i < presentationRecord.presentationChildren().length; ++i)
+ dumpFormattedRecord(presentationRecord.presentationChildren()[i], childPrefix);
+ }
}
WebInspector.panels.timeline._model._collectionEnabled = false;
- var records = WebInspector.panels.timeline._currentViews[0]._rootRecord().children;
+ var records = WebInspector.panels.timeline._currentViews[0]._rootRecord().presentationChildren();
for (var i = 0; i < records.length; ++i)
dumpFormattedRecord(records[i]);
InspectorTest.completeTest();
« no previous file with comments | « LayoutTests/inspector/timeline/timeline-network-resource.html ('k') | LayoutTests/inspector/timeline/timeline-time.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698