Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1695)

Unified Diff: Source/devtools/front_end/TimelineFrameModel.js

Issue 183893010: DevTools: extract TimelineModel.Record from TimelinePresentationModel.Record. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: For landing Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/TimelineFrameModel.js
diff --git a/Source/devtools/front_end/TimelineFrameModel.js b/Source/devtools/front_end/TimelineFrameModel.js
index c4003479d6105864f99396045ce21805bd4ab344..87ac921d64e7e2413105554ae161a60c57bcf59a 100644
--- a/Source/devtools/front_end/TimelineFrameModel.js
+++ b/Source/devtools/front_end/TimelineFrameModel.js
@@ -38,7 +38,7 @@ WebInspector.TimelineFrameModel = function(model)
this._model = model;
this.reset();
- var records = model.records;
+ var records = model.records();
for (var i = 0; i < records.length; ++i)
this.addRecord(records[i]);
}
@@ -89,7 +89,7 @@ WebInspector.TimelineFrameModel.prototype = {
},
/**
- * @param {!TimelineAgent.TimelineEvent} record
+ * @param {!WebInspector.TimelineModel.Record} record
*/
addRecord: function(record)
{
@@ -112,7 +112,7 @@ WebInspector.TimelineFrameModel.prototype = {
},
/**
- * @param {!TimelineAgent.TimelineEvent} record
+ * @param {!WebInspector.TimelineModel.Record} record
*/
_addBackgroundRecord: function(record)
{
@@ -141,8 +141,8 @@ WebInspector.TimelineFrameModel.prototype = {
},
/**
- * @param {?TimelineAgent.TimelineEvent} programRecord
- * @param {!TimelineAgent.TimelineEvent} record
+ * @param {?WebInspector.TimelineModel.Record} programRecord
+ * @param {!WebInspector.TimelineModel.Record} record
*/
_addMainThreadRecord: function(programRecord, record)
{
@@ -178,7 +178,7 @@ WebInspector.TimelineFrameModel.prototype = {
},
/**
- * @param {!TimelineAgent.TimelineEvent} programRecord
+ * @param {!WebInspector.TimelineModel.Record} programRecord
* @param {!Object} timeByCategory
*/
_deriveOtherTime: function(programRecord, timeByCategory)
@@ -191,7 +191,7 @@ WebInspector.TimelineFrameModel.prototype = {
},
/**
- * @param {!TimelineAgent.TimelineEvent} record
+ * @param {!WebInspector.TimelineModel.Record} record
*/
_startBackgroundFrame: function(record)
{
@@ -206,7 +206,7 @@ WebInspector.TimelineFrameModel.prototype = {
},
/**
- * @param {!TimelineAgent.TimelineEvent} record
+ * @param {!WebInspector.TimelineModel.Record} record
*/
_startMainThreadFrame: function(record)
{
@@ -228,8 +228,8 @@ WebInspector.TimelineFrameModel.prototype = {
/**
* @param {!Array.<string>} types
- * @param {!TimelineAgent.TimelineEvent} record
- * @return {?TimelineAgent.TimelineEvent} record
+ * @param {!WebInspector.TimelineModel.Record} record
+ * @return {?WebInspector.TimelineModel.Record} record
*/
_findRecordRecursively: function(types, record)
{
@@ -303,7 +303,7 @@ WebInspector.TimelineFrame.prototype = {
},
/**
- * @param {!TimelineAgent.TimelineEvent} record
+ * @param {!WebInspector.TimelineModel.Record} record
*/
_addTimeFromRecord: function(record)
{
« no previous file with comments | « Source/devtools/front_end/TimelineFlameChart.js ('k') | Source/devtools/front_end/TimelineMemoryOverview.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698