LayoutTests/inspector/timeline/timeline-filtering.html - Issue 183893010: DevTools: extract TimelineModel.Record from TimelinePresentationModel.Record.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/inspector/timeline/timeline-filtering.html

Issue 183893010: DevTools: extract TimelineModel.Record from TimelinePresentationModel.Record. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: For landing Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/timeline/timeline-dom-content-loaded-event.html ('k') | LayoutTests/inspector/timeline/timeline-load.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/inspector/timeline/timeline-filtering.html

diff --git a/LayoutTests/inspector/timeline/timeline-filtering.html b/LayoutTests/inspector/timeline/timeline-filtering.html

index b17f222fb581437076c2ebba8fe9bc8e36f25b02..2e3476aeffa71eeebafc79240ae9eddafd975011 100644

--- a/LayoutTests/inspector/timeline/timeline-filtering.html

+++ b/LayoutTests/inspector/timeline/timeline-filtering.html

@@ -44,12 +44,12 @@ function test()

function printRecord(record)

{

var prefix = [];

- var current = record.parent;

+ var current = record.presentationParent();

while (current) {

- current = current.parent;

+ current = current.presentationParent();

prefix.push(" ");

}

- var mark = record.expandable ? (record.collapsed ? "+" : "-") : " ";

+ var mark = record.expandable() ? (record.collapsed() ? "+" : "-") : " ";

InspectorTest.addResult(prefix.join("") + mark + record._record.data.message);

}

@@ -76,7 +76,7 @@ function test()

for (var i = 0; i < records.length; ++i) {

var record = records[i];

if (collapseList[record._record.data.message]) {

- record.collapsed = true;

+ record.setCollapsed(true);

record.clicked = true;

}