Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: Source/devtools/front_end/TimelineFlameChart.js

Issue 183893010: DevTools: extract TimelineModel.Record from TimelinePresentationModel.Record. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: For landing Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/TimelineEventOverview.js ('k') | Source/devtools/front_end/TimelineFrameModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/TimelineFlameChart.js
diff --git a/Source/devtools/front_end/TimelineFlameChart.js b/Source/devtools/front_end/TimelineFlameChart.js
index cd7e675d4e2fe8418132dd003b976519ee86cbcb..eae262a0d575d400227d3ca250c924545694c7f2 100644
--- a/Source/devtools/front_end/TimelineFlameChart.js
+++ b/Source/devtools/front_end/TimelineFlameChart.js
@@ -98,7 +98,7 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {
},
/**
- * @param {!TimelineAgent.TimelineEvent} record
+ * @param {!WebInspector.TimelineModel.Record} record
*/
addRecord: function(record)
{
@@ -125,7 +125,7 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {
{
if (!this._timelineData) {
this._resetData();
- WebInspector.TimelinePresentationModel.forAllRecords(this._model.records, this._appendRecord.bind(this));
+ this._model.forAllRecords(this._appendRecord.bind(this));
this._zeroTime = this._model.minimumRecordTime();
}
return this._timelineData;
@@ -172,6 +172,10 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {
this._entryTitles = [];
},
+ /**
+ * @param {!WebInspector.TimelineModel.Record} record
+ * @param {number} depth
+ */
_appendRecord: function(record, depth)
{
var timelineData = this._timelineData;
@@ -281,15 +285,14 @@ WebInspector.TimelineFlameChart.prototype = {
},
/**
- * @param {!TimelineAgent.TimelineEvent} rawRecord
- * @param {!Array.<!WebInspector.TimelinePresentationModel.Record>} presentationRecords
+ * @param {!WebInspector.TimelineModel.Record} record
*/
- addRecord: function(rawRecord, presentationRecords)
+ addRecord: function(record)
{
- this._dataProvider.addRecord(rawRecord);
+ this._dataProvider.addRecord(record);
if (this._automaticallySizeWindow) {
var minimumRecordTime = this._model.minimumRecordTime();
- if (rawRecord.startTime > (minimumRecordTime + 1000)) {
+ if (record.startTime > (minimumRecordTime + 1000)) {
this._automaticallySizeWindow = false;
this._delegate.requestWindowTimes(minimumRecordTime, minimumRecordTime + 1000);
}
@@ -326,7 +329,7 @@ WebInspector.TimelineFlameChart.prototype = {
},
/**
- * @param {?WebInspector.TimelinePresentationModel.Record} record
+ * @param {?WebInspector.TimelineModel.Record} record
* @param {string=} regex
* @param {boolean=} selectRecord
*/
@@ -335,7 +338,7 @@ WebInspector.TimelineFlameChart.prototype = {
},
/**
- * @param {?WebInspector.TimelinePresentationModel.Record} record
+ * @param {?WebInspector.TimelineModel.Record} record
*/
setSelectedRecord: function(record)
{
« no previous file with comments | « Source/devtools/front_end/TimelineEventOverview.js ('k') | Source/devtools/front_end/TimelineFrameModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698