Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1768)

Unified Diff: Source/devtools/front_end/TimelineOverviewPane.js

Issue 183893010: DevTools: extract TimelineModel.Record from TimelinePresentationModel.Record. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: For landing Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/TimelineModel.js ('k') | Source/devtools/front_end/TimelinePanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/TimelineOverviewPane.js
diff --git a/Source/devtools/front_end/TimelineOverviewPane.js b/Source/devtools/front_end/TimelineOverviewPane.js
index 1ebae9c96af098b9093874f14d71015a3d48ce56..2e6072958165d9453796eff76c8b2ea30e192bd6 100644
--- a/Source/devtools/front_end/TimelineOverviewPane.js
+++ b/Source/devtools/front_end/TimelineOverviewPane.js
@@ -118,7 +118,7 @@ WebInspector.TimelineOverviewPane.prototype = {
},
/**
- * @param {!TimelineAgent.TimelineEvent} record
+ * @param {!WebInspector.TimelineModel.Record} record
*/
addRecord: function(record)
{
@@ -128,7 +128,7 @@ WebInspector.TimelineOverviewPane.prototype = {
if (WebInspector.TimelineUIUtils.isEventDivider(record))
eventDividers.push(record);
}
- WebInspector.TimelinePresentationModel.forAllRecords([record], addEventDividers);
+ WebInspector.TimelineModel.forAllRecords([record], addEventDividers);
this._scheduleRefresh();
},
@@ -168,7 +168,7 @@ WebInspector.TimelineOverviewPane.prototype = {
var windowBoundaries = this._overviewControl.windowBoundaries(startTime, endTime);
this._muteOnWindowChanged = true;
this._overviewGrid.setWindow(windowBoundaries.left, windowBoundaries.right);
- this._overviewGrid.setResizeEnabled(this._model.records.length);
+ this._overviewGrid.setResizeEnabled(!!this._model.records().length);
this._muteOnWindowChanged = false;
this.dispatchEventToListeners(WebInspector.TimelineOverviewPane.Events.WindowChanged, { startTime: startTime, endTime: endTime });
« no previous file with comments | « Source/devtools/front_end/TimelineModel.js ('k') | Source/devtools/front_end/TimelinePanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698