Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: Source/devtools/front_end/TimelineEventOverview.js

Issue 183893010: DevTools: extract TimelineModel.Record from TimelinePresentationModel.Record. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: For landing Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/MemoryStatistics.js ('k') | Source/devtools/front_end/TimelineFlameChart.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/TimelineEventOverview.js
diff --git a/Source/devtools/front_end/TimelineEventOverview.js b/Source/devtools/front_end/TimelineEventOverview.js
index ff5cb6a8566da9ea33ea131bc15186a86e94c091..adadea2a1ef3daafd0b1d25d743388bccf0a14f7 100644
--- a/Source/devtools/front_end/TimelineEventOverview.js
+++ b/Source/devtools/front_end/TimelineEventOverview.js
@@ -75,6 +75,7 @@ WebInspector.TimelineEventOverview.prototype = {
this._context.fillRect(0.5, i * stripHeight + 0.5, this._canvas.width, stripHeight);
/**
+ * @param {!WebInspector.TimelineModel.Record} record
* @this {WebInspector.TimelineEventOverview}
*/
function appendRecord(record)
@@ -98,7 +99,7 @@ WebInspector.TimelineEventOverview.prototype = {
this._renderBar(bar.start, bar.end, stripHeight, bar.category);
lastBarByGroup[category.overviewStripGroupIndex] = { start: recordStart, end: recordEnd, category: category };
}
- WebInspector.TimelinePresentationModel.forAllRecords(this._model.records, appendRecord.bind(this));
+ this._model.forAllRecords(appendRecord.bind(this));
for (var i = 0; i < lastBarByGroup.length; ++i) {
if (lastBarByGroup[i])
this._renderBar(lastBarByGroup[i].start, lastBarByGroup[i].end, stripHeight, lastBarByGroup[i].category);
« no previous file with comments | « Source/devtools/front_end/MemoryStatistics.js ('k') | Source/devtools/front_end/TimelineFlameChart.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698