Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1826633002: [Findit] Extract and pass failed targets from ninja to try-job. (Closed)

Created:
4 years, 9 months ago by stgao
Modified:
3 years, 7 months ago
Reviewers:
chanli, lijeffrey
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Sharu Jiang
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Extract and pass failed targets from ninja to try-job. BUG=596970

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -8 lines) Patch
M appengine/findit/waterfall/build_info.py View 2 chunks +2 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/buildbot.py View 1 chunk +2 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/detect_first_failure_pipeline.py View 1 2 chunks +6 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/test/try_job_util_test.py View 1 3 chunks +18 lines, -4 lines 0 comments Download
M appengine/findit/waterfall/try_job_util.py View 1 2 chunks +14 lines, -4 lines 3 comments Download

Messages

Total messages: 4 (2 generated)
stgao
hey Chan and Jeff, Even though the recipe change (https://codereview.chromium.org/1766873002/) is not landed yet, I'd ...
4 years, 7 months ago (2016-04-27 20:18:32 UTC) #2
chanli
4 years, 7 months ago (2016-04-27 22:51:34 UTC) #4 
https://codereview.chromium.org/1826633002/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/try_job_util.py (right):

https://codereview.chromium.org/1826633002/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/try_job_util.py:116: def
_GetFailedTargetsFromSignals(
Should we change the function name since now we may get failed targets from
compile_failures directly?

https://codereview.chromium.org/1826633002/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/try_job_util.py:118: # Use failed targets from
builder on waterfall if they are available.
'build' or 'builder'?

https://codereview.chromium.org/1826633002/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/try_job_util.py:120: not
compile_failures.get('unknown_failures') and
I didn't find 'unknown_failures' in https://codereview.chromium.org/1766873002/
?

Powered by Google App Engine
This is Rietveld 408576698