appengine/findit/waterfall/detect_first_failure_pipeline.py - Issue 1826633002: [Findit] Extract and pass failed targets from ninja to try-job.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/detect_first_failure_pipeline.py

Issue 1826633002: [Findit] Extract and pass failed targets from ninja to try-job. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/buildbot.py ('k') | appengine/findit/waterfall/test/try_job_util_test.py » ('j') | appengine/findit/waterfall/try_job_util.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/detect_first_failure_pipeline.py

diff --git a/appengine/findit/waterfall/detect_first_failure_pipeline.py b/appengine/findit/waterfall/detect_first_failure_pipeline.py

index f5f728a9be271054396a457314413c4da6c4ef58..6679213f6e5c395a39d4a13e8b3f02c0a7de5124 100644

--- a/appengine/findit/waterfall/detect_first_failure_pipeline.py

+++ b/appengine/findit/waterfall/detect_first_failure_pipeline.py

@@ -421,6 +421,11 @@ class DetectFirstFailurePipeline(BasePipeline):

...

}

+ },

+ "compile_failures": {

+ "failed_targets": ["obj/path/to/file.o"],

+ "unknown_targets": [],

+ "unrecognized_format": false,

}

"""

@@ -440,6 +445,7 @@ class DetectFirstFailurePipeline(BasePipeline):

'builds': {},

'failed_steps': {},

'failure_type': build_failure_type,

+ 'compile_failures': build_info.compile_failures,

}

if build_info.result == buildbot.SUCCESS or not build_info.failed_steps: