| Index: appengine/findit/waterfall/test/try_job_util_test.py
|
| diff --git a/appengine/findit/waterfall/test/try_job_util_test.py b/appengine/findit/waterfall/test/try_job_util_test.py
|
| index 65f58afd018607153b19bd295ca23bac3e0c5073..f9641fcc4b030490552ef44ca1c4d8ce9698a75b 100644
|
| --- a/appengine/findit/waterfall/test/try_job_util_test.py
|
| +++ b/appengine/findit/waterfall/test/try_job_util_test.py
|
| @@ -376,10 +376,11 @@ class TryJobUtilTest(wf_testcase.WaterfallTestCase):
|
|
|
| def testGetFailedTargetsFromSignals(self):
|
| self.assertEqual(
|
| - try_job_util._GetFailedTargetsFromSignals({}, 'm', 'b'), [])
|
| + try_job_util._GetFailedTargetsFromSignals(None, {}, 'm', 'b'), [])
|
|
|
| self.assertEqual(
|
| - try_job_util._GetFailedTargetsFromSignals({'compile': {}}, 'm', 'b'),
|
| + try_job_util._GetFailedTargetsFromSignals(
|
| + None, {'compile': {}}, 'm', 'b'),
|
| [])
|
|
|
| signals = {
|
| @@ -392,7 +393,20 @@ class TryJobUtilTest(wf_testcase.WaterfallTestCase):
|
| }
|
|
|
| self.assertEqual(
|
| - try_job_util._GetFailedTargetsFromSignals(signals, 'm', 'b'), ['a.exe'])
|
| + try_job_util._GetFailedTargetsFromSignals(None, signals, 'm', 'b'),
|
| + ['a.exe'])
|
| +
|
| + def testGetFailedTargetsFromSignalsUsingCompileFailruesInfo(self):
|
| + compile_failures = {
|
| + 'unrecognized_format': False,
|
| + 'failed_targets': ['obj/a.o'],
|
| + 'unknown_targets': ['obj/b.o'],
|
| + }
|
| +
|
| + self.assertEqual(
|
| + try_job_util._GetFailedTargetsFromSignals(
|
| + compile_failures, None, None, None),
|
| + ['obj/a.o', 'obj/b.o'])
|
|
|
| def testUseObjectFilesAsFailedTargetIfStrictRegexUsed(self):
|
| signals = {
|
| @@ -405,7 +419,7 @@ class TryJobUtilTest(wf_testcase.WaterfallTestCase):
|
|
|
| self.assertEqual(
|
| try_job_util._GetFailedTargetsFromSignals(
|
| - signals, 'master1', 'builder1'),
|
| + None, signals, 'master1', 'builder1'),
|
| ['b.o'])
|
|
|
| def testGetSuspectsForCompileFailureFromHeuristicResult(self):
|
|
|