appengine/findit/waterfall/build_info.py - Issue 1826633002: [Findit] Extract and pass failed targets from ninja to try-job.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/build_info.py

Issue 1826633002: [Findit] Extract and pass failed targets from ninja to try-job. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/findit/waterfall/build_info.py

diff --git a/appengine/findit/waterfall/build_info.py b/appengine/findit/waterfall/build_info.py

index dc95b7535d93284a4fb4376551322356d8c24f80..0e527c0eec9891bb94a40a4dcb67432f3363111d 100644

--- a/appengine/findit/waterfall/build_info.py

+++ b/appengine/findit/waterfall/build_info.py

@@ -14,6 +14,7 @@ class BuildInfo(object): # pragma: no cover

self.completed = False

self.result = None

self.blame_list = []

+ self.compile_failures = None

self.failed_steps = []

self.passed_steps = []

self.not_passed_steps = []

@@ -27,6 +28,7 @@ class BuildInfo(object): # pragma: no cover

print 'completed: %s' % self.completed

print 'result: %s' % self.result

print 'CLs: %s' % ', '.join(self.blame_list)

+ print 'Compile failures: %r' % self.compile_failures

print 'Failed steps: %s' % ', '.join(self.failed_steps)

print 'Passed steps: %s' % ', '.join(self.passed_steps)

print 'Not-passed steps: %s' % ', '.join(self.not_passed_steps)

« no previous file with comments | « no previous file | appengine/findit/waterfall/buildbot.py » ('j') | appengine/findit/waterfall/try_job_util.py » ('J')