[Findit] Extract and pass failed targets from ninja to try-job.

appengine/findit/waterfall/try_job_util.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 
 from google.appengine.ext import ndb
 
 from common import appengine_util
 from common import constants
@@ skipping 95 matching lines @@
         try_job.put()
       else:
         need_new_try_job = False
     else:
       try_job = WfTryJob.Create(master_name, builder_name, build_number)
       try_job.put()
 
   return need_new_try_job, last_pass, try_job_type, targeted_tests
 
 
-def _GetFailedTargetsFromSignals(signals, master_name, builder_name):
+def _GetFailedTargetsFromSignals(

[chanli, 2016/04/27 22:51:34]

Should we change the function name since now we may get failed targets from
compile_failures directly?

+    compile_failures, signals, master_name, builder_name):
+  # Use failed targets from builder on waterfall if they are available.

[chanli, 2016/04/27 22:51:34]

'build' or 'builder'?

+  if (compile_failures and
+      not compile_failures.get('unknown_failures') and

[chanli, 2016/04/27 22:51:34]

I didn't find 'unknown_failures' in https://codereview.chromium.org/1766873002/
?

+      not compile_failures.get('unrecognized_format')):
+    return (compile_failures.get('failed_targets') +
+            compile_failures.get('unknown_targets'))
+
   compile_targets = []
 
   if not signals or 'compile' not in signals:
     return compile_targets
 
   strict_regex = waterfall_config.EnableStrictRegexForCompileLinkFailures(
       master_name, builder_name)
   for source_target in signals['compile'].get('failed_targets', []):
     # For link failures, we pass the executable targets directly to try-job, and
     # there is no 'source' for link failures.
@@ skipping 33 matching lines @@
     logging.info('Test try jobs on %s, %s are not supported yet.',
                  master_name, builder_name)
     return {}
 
   failure_result_map = {}
   need_new_try_job, last_pass, try_job_type, targeted_tests = (
       _NeedANewTryJob(master_name, builder_name, build_number,
                       failed_steps, failure_result_map))
 
   if need_new_try_job:
-    compile_targets = (_GetFailedTargetsFromSignals(
-        signals, master_name, builder_name)
-                       if try_job_type == TryJobType.COMPILE else None)
+    compile_targets = (
+        None if try_job_type != TryJobType.COMPILE else
+        _GetFailedTargetsFromSignals(
+            failure_info.get('compile_failures'),
+            signals, master_name, builder_name))
     suspected_revisions = (
         _GetSuspectsForCompileFailureFromHeuristicResult(heuristic_result)
         if try_job_type == TryJobType.COMPILE else None)
 
     pipeline = (
         swarming_tasks_to_try_job_pipeline.SwarmingTasksToTryJobPipeline(
             master_name, builder_name, build_number,
             builds[str(last_pass)]['chromium_revision'],
             builds[str(build_number)]['chromium_revision'],
             builds[str(build_number)]['blame_list'],
@@ skipping 12 matching lines @@
               pipeline.pipeline_status_path, try_job_type)
     else:  # pragma: no cover
       logging_str = (
           'Try job was scheduled for build %s, %s, %s: %s because of %s '
           'failure.') % (
               master_name, builder_name, build_number,
               pipeline.pipeline_status_path, try_job_type)
     logging.info(logging_str)
 
   return failure_result_map