[Findit] Extract and pass failed targets from ninja to try-job.

appengine/findit/waterfall/try_job_util.py

Index: appengine/findit/waterfall/try_job_util.py
diff --git a/appengine/findit/waterfall/try_job_util.py b/appengine/findit/waterfall/try_job_util.py
index bd906f37c612b7cde7e9dfbadfd75ee851029697..084691d4f78de9cf3a35f605cd7f5dfe03613ffc 100644
--- a/appengine/findit/waterfall/try_job_util.py
+++ b/appengine/findit/waterfall/try_job_util.py
@@ -113,7 +113,15 @@ def _NeedANewTryJob(
   return need_new_try_job, last_pass, try_job_type, targeted_tests
 
 
-def _GetFailedTargetsFromSignals(signals, master_name, builder_name):
+def _GetFailedTargetsFromSignals(

[chanli, 2016/04/27 22:51:34]

Should we change the function name since now we may get failed targets from
compile_failures directly?

+    compile_failures, signals, master_name, builder_name):
+  # Use failed targets from builder on waterfall if they are available.

[chanli, 2016/04/27 22:51:34]

'build' or 'builder'?

+  if (compile_failures and
+      not compile_failures.get('unknown_failures') and

[chanli, 2016/04/27 22:51:34]

I didn't find 'unknown_failures' in https://codereview.chromium.org/1766873002/
?

+      not compile_failures.get('unrecognized_format')):
+    return (compile_failures.get('failed_targets') +
+            compile_failures.get('unknown_targets'))
+
   compile_targets = []
 
   if not signals or 'compile' not in signals:
@@ -167,9 +175,11 @@ def ScheduleTryJobIfNeeded(failure_info, signals, heuristic_result):
                       failed_steps, failure_result_map))
 
   if need_new_try_job:
-    compile_targets = (_GetFailedTargetsFromSignals(
-        signals, master_name, builder_name)
-                       if try_job_type == TryJobType.COMPILE else None)
+    compile_targets = (
+        None if try_job_type != TryJobType.COMPILE else
+        _GetFailedTargetsFromSignals(
+            failure_info.get('compile_failures'),
+            signals, master_name, builder_name))
     suspected_revisions = (
         _GetSuspectsForCompileFailureFromHeuristicResult(heuristic_result)
         if try_job_type == TryJobType.COMPILE else None)