[Findit] Extract and pass failed targets from ninja to try-job.

appengine/findit/waterfall/test/try_job_util_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from common.waterfall import failure_type
 from model import analysis_status
 from model.wf_try_job import WfTryJob
 from waterfall import try_job_util
 from waterfall.test import wf_testcase
 from waterfall.try_job_type import TryJobType
@@ skipping 358 matching lines @@
 
     try_job_util.ScheduleTryJobIfNeeded(failure_info, None, None)
 
     try_job = WfTryJob.Get(master_name, builder_name, build_number)
 
     self.assertTrue(_MockRootPipeline.STARTED)
     self.assertIsNotNone(try_job)
 
   def testGetFailedTargetsFromSignals(self):
     self.assertEqual(
-        try_job_util._GetFailedTargetsFromSignals({}, 'm', 'b'), [])
+        try_job_util._GetFailedTargetsFromSignals(None, {}, 'm', 'b'), [])
 
     self.assertEqual(
-        try_job_util._GetFailedTargetsFromSignals({'compile': {}}, 'm', 'b'),
+        try_job_util._GetFailedTargetsFromSignals(
+            None, {'compile': {}}, 'm', 'b'),
         [])
 
     signals = {
         'compile': {
             'failed_targets': [
                 {'target': 'a.exe'},
                 {'source': 'b.cc',
                  'target': 'b.o'}]
         }
     }
 
     self.assertEqual(
-        try_job_util._GetFailedTargetsFromSignals(signals, 'm', 'b'), ['a.exe'])
+        try_job_util._GetFailedTargetsFromSignals(None, signals, 'm', 'b'),
+        ['a.exe'])
+
+  def testGetFailedTargetsFromSignalsUsingCompileFailruesInfo(self):
+    compile_failures = {
+        'unrecognized_format': False,
+        'failed_targets': ['obj/a.o'],
+        'unknown_targets': ['obj/b.o'],
+    }
+
+    self.assertEqual(
+        try_job_util._GetFailedTargetsFromSignals(
+            compile_failures, None, None, None),
+        ['obj/a.o', 'obj/b.o'])
 
   def testUseObjectFilesAsFailedTargetIfStrictRegexUsed(self):
     signals = {
         'compile': {
             'failed_targets': [
                 {'source': 'b.cc', 'target': 'b.o'},
             ]
         }
     }
 
     self.assertEqual(
         try_job_util._GetFailedTargetsFromSignals(
-            signals, 'master1', 'builder1'),
+            None, signals, 'master1', 'builder1'),
         ['b.o'])
 
   def testGetSuspectsForCompileFailureFromHeuristicResult(self):
     heuristic_result = {
         'failures': [
             {
                 'step_name': 'compile',
                 'suspected_cls': [
                     {
                         'revision': 'r1',
                     },
                     {
                         'revision': 'r2',
                     },
                 ],
             },
             {
                 'step_name': 'steps'
             },
         ]
     }
     expected_suspected_revisions = ['r1', 'r2']
     self.assertEqual(
         expected_suspected_revisions,
         try_job_util._GetSuspectsForCompileFailureFromHeuristicResult(
             heuristic_result))