appengine/findit/waterfall/buildbot.py - Issue 1826633002: [Findit] Extract and pass failed targets from ninja to try-job.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/buildbot.py

Issue 1826633002: [Findit] Extract and pass failed targets from ninja to try-job. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/build_info.py ('k') | appengine/findit/waterfall/detect_first_failure_pipeline.py » ('j') | appengine/findit/waterfall/try_job_util.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/buildbot.py

diff --git a/appengine/findit/waterfall/buildbot.py b/appengine/findit/waterfall/buildbot.py

index 0709671b2cdcc27543316f8ed9e0b12eb7c93096..a631834eb99a8fa462154d9993f482b99488b995 100644

--- a/appengine/findit/waterfall/buildbot.py

+++ b/appengine/findit/waterfall/buildbot.py

@@ -198,6 +198,8 @@ def ExtractBuildInfo(master_name, builder_name, build_number, build_data):

build_info.chromium_revision = chromium_revision

build_info.completed = data_json.get('currentStep') is None

build_info.result = GetBuildResult(data_json)

+ build_info.compile_failures = GetBuildProperty(

+ data_json.get('properties', []), 'compile_failures')

changes = data_json.get('sourceStamp', {}).get('changes', [])

for change in changes: