[Extensions] Convert APIs to use movable types [7]

[Extensions] Convert APIs to use movable types [7]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- language_settings_private.idl
- launcher_page.idl
- launcher_search_provider.idl
- log_private.idl
- manifest_types.json
- mdns.idl
- media_galleries.idl
- media_player_private.json
- metrics_private.json
- music_manager_private.idl
- notification_provider.idl
- notifications.idl

BUG=595949
Committed: https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6
Cr-Commit-Position: refs/heads/master@{#383746}

[Devlin, 2016-03-24 21:13:43]

rdevlin.cronin@chromium.org changed reviewers:
+ asargent@chromium.org

[asargent_no_longer_on_chrome, 2016-03-25 17:18:31]

lgtm, but looks like you're getting failures with some of the MediaGalleries
tests.

The c++ looks not-obviously-wrong, so maybe a bug in the generated code? Perhaps
something related to the fact that we have an array of StreamInfo in
MediaMetadata or something like that?

[Devlin, 2016-03-25 18:07:25]

On 2016/03/25 17:18:31, Antony Sargent wrote:
> lgtm, but looks like you're getting failures with some of the MediaGalleries
> tests.
> 
> The c++ looks not-obviously-wrong, so maybe a bug in the generated code?
Perhaps
> something related to the fact that we have an array of StreamInfo in
> MediaMetadata or something like that?

The red trybot runs are from before I landed the change to move
|additional_properties| - I re-ran them after the patch landed and they're all
green. :)

[Devlin, 2016-03-25 19:40:07]

rdevlin.cronin@chromium.org changed reviewers:
+ stevenjb@chromium.org, tommycli@chromium.org

[Devlin, 2016-03-25 19:40:08]

+Steven for c/b/notifications and c/b/chromeos
+Tommy for c/utility/media_galleries

[tommycli, 2016-03-25 19:57:21]

media_galleries LGTM

[stevenjb, 2016-03-29 00:18:49]

This is great, I've never been super fond of the need to use linked_ptr in these
apis.
LGTM

https://codereview.chromium.org/1825913002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/log_private/syslog_parser.cc (right):

https://codereview.chromium.org/1825913002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/log_private/syslog_parser.cc:37:
api::log_private::LogEntry entry;
nit: move closer to where it is used

[Devlin, 2016-03-29 14:22:39]

https://codereview.chromium.org/1825913002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/log_private/syslog_parser.cc (right):

https://codereview.chromium.org/1825913002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/log_private/syslog_parser.cc:37:
api::log_private::LogEntry entry;
On 2016/03/29 00:18:49, stevenjb wrote:
> nit: move closer to where it is used

Done.

[Devlin, 2016-03-29 16:50:06]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-03-29 16:50:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org, stevenjb@chromium.org, asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/1825913002/#ps20001
(title: "Steven's")

[commit-bot: I haz the power, 2016-03-29 16:50:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825913002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825913002/20001

[commit-bot: I haz the power, 2016-03-29 16:57:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-29 16:59:41]

Description was changed from

==========
[Extensions] Convert APIs to use movable types [7]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- language_settings_private.idl
- launcher_page.idl
- launcher_search_provider.idl
- log_private.idl
- manifest_types.json
- mdns.idl
- media_galleries.idl
- media_player_private.json
- metrics_private.json
- music_manager_private.idl
- notification_provider.idl
- notifications.idl

BUG=595949
==========

to

==========
[Extensions] Convert APIs to use movable types [7]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- language_settings_private.idl
- launcher_page.idl
- launcher_search_provider.idl
- log_private.idl
- manifest_types.json
- mdns.idl
- media_galleries.idl
- media_player_private.json
- metrics_private.json
- music_manager_private.idl
- notification_provider.idl
- notifications.idl

BUG=595949

Committed: https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6
Cr-Commit-Position: refs/heads/master@{#383746}
==========

[commit-bot: I haz the power, 2016-03-29 16:59:43]

Patchset 2 (id:??) landed as
https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6
Cr-Commit-Position: refs/heads/master@{#383746}