Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1731)

Unified Diff: chrome/browser/extensions/api/log_private/log_parser.h

Issue 1825913002: [Extensions] Convert APIs to use movable types [7] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Steven's Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/log_private/log_parser.h
diff --git a/chrome/browser/extensions/api/log_private/log_parser.h b/chrome/browser/extensions/api/log_private/log_parser.h
index 4225afa99fa5a4e871a43b0cc7ce9453786135e0..38861c8359f2f24db4ee6dda8fb5a96fd4139f9d 100644
--- a/chrome/browser/extensions/api/log_private/log_parser.h
+++ b/chrome/browser/extensions/api/log_private/log_parser.h
@@ -9,7 +9,6 @@
#include <vector>
#include "base/macros.h"
-#include "base/memory/linked_ptr.h"
#include "chrome/browser/extensions/api/log_private/filter_handler.h"
#include "chrome/common/extensions/api/log_private.h"
@@ -28,18 +27,16 @@ class LogParser {
virtual ~LogParser();
// Parses log text into multiple LogEntry objects.
- void Parse(
- const std::string& input,
- std::vector<linked_ptr<api::log_private::LogEntry> >* output,
- FilterHandler* filter_handler) const;
+ void Parse(const std::string& input,
+ std::vector<api::log_private::LogEntry>* output,
+ FilterHandler* filter_handler) const;
protected:
- explicit LogParser();
+ LogParser();
// Parses a single line of log text into one LogEntry object.
- virtual Error ParseEntry(
- const std::string& input,
- std::vector<linked_ptr<api::log_private::LogEntry> >* output,
- FilterHandler* filter_handler) const = 0;
+ virtual Error ParseEntry(const std::string& input,
+ std::vector<api::log_private::LogEntry>* output,
+ FilterHandler* filter_handler) const = 0;
private:
DISALLOW_COPY_AND_ASSIGN(LogParser);

Powered by Google App Engine
This is Rietveld 408576698