Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: chrome/browser/extensions/api/log_private/syslog_parser_unittest.cc

Issue 1825913002: [Extensions] Convert APIs to use movable types [7] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Steven's Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/log_private/syslog_parser_unittest.cc
diff --git a/chrome/browser/extensions/api/log_private/syslog_parser_unittest.cc b/chrome/browser/extensions/api/log_private/syslog_parser_unittest.cc
index ee5196b6a39630cb3d0f39527011f1f632c77128..d980c5316bb2148d9cbb7b6881372068e2deb98f 100644
--- a/chrome/browser/extensions/api/log_private/syslog_parser_unittest.cc
+++ b/chrome/browser/extensions/api/log_private/syslog_parser_unittest.cc
@@ -32,7 +32,7 @@ class ExtensionSyslogParserTest : public testing::Test {
};
TEST_F(ExtensionSyslogParserTest, ParseLog) {
- std::vector<linked_ptr<api::log_private::LogEntry> > output;
+ std::vector<api::log_private::LogEntry> output;
api::log_private::Filter filter;
FilterHandler filter_handler(filter);
SyslogParser p;
@@ -40,29 +40,29 @@ TEST_F(ExtensionSyslogParserTest, ParseLog) {
// Test kernel log
p.Parse(kKernelLogEntry, &output, &filter_handler);
ASSERT_EQ(1u, output.size());
- EXPECT_EQ("unknown", output[0]->level);
- EXPECT_EQ("kernel", output[0]->process);
- EXPECT_EQ("unknown", output[0]->process_id);
- EXPECT_EQ(kKernelLogEntry, output[0]->full_entry);
- EXPECT_DOUBLE_EQ(1408395898606.132, output[0]->timestamp);
+ EXPECT_EQ("unknown", output[0].level);
+ EXPECT_EQ("kernel", output[0].process);
+ EXPECT_EQ("unknown", output[0].process_id);
+ EXPECT_EQ(kKernelLogEntry, output[0].full_entry);
+ EXPECT_DOUBLE_EQ(1408395898606.132, output[0].timestamp);
// Test shill log
p.Parse(kShillLogEntry, &output, &filter_handler);
ASSERT_EQ(2u, output.size());
- EXPECT_EQ("info", output[1]->level);
- EXPECT_EQ("shill", output[1]->process);
- EXPECT_EQ("1018", output[1]->process_id);
- EXPECT_EQ(kShillLogEntry, output[1]->full_entry);
- EXPECT_DOUBLE_EQ(1408126824575.058, output[1]->timestamp);
+ EXPECT_EQ("info", output[1].level);
+ EXPECT_EQ("shill", output[1].process);
+ EXPECT_EQ("1018", output[1].process_id);
+ EXPECT_EQ(kShillLogEntry, output[1].full_entry);
+ EXPECT_DOUBLE_EQ(1408126824575.058, output[1].timestamp);
// Test WpaSupplicant log
p.Parse(kWpaSupplicantLogEntry, &output, &filter_handler);
ASSERT_EQ(3u, output.size());
- EXPECT_EQ("unknown", output[2]->level);
- EXPECT_EQ("wpa_supplicant", output[2]->process);
- EXPECT_EQ("818", output[2]->process_id);
- EXPECT_EQ(kWpaSupplicantLogEntry, output[2]->full_entry);
- EXPECT_DOUBLE_EQ(1408131366137.021, output[2]->timestamp);
+ EXPECT_EQ("unknown", output[2].level);
+ EXPECT_EQ("wpa_supplicant", output[2].process);
+ EXPECT_EQ("818", output[2].process_id);
+ EXPECT_EQ(kWpaSupplicantLogEntry, output[2].full_entry);
+ EXPECT_DOUBLE_EQ(1408131366137.021, output[2].timestamp);
}
} // namespace extensions
« no previous file with comments | « chrome/browser/extensions/api/log_private/syslog_parser.cc ('k') | chrome/browser/extensions/api/mdns/mdns_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698