[Extensions] Convert APIs to use movable types [7]

chrome/browser/extensions/api/notifications/notifications_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/notifications/notifications_api.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 304 matching lines @@
     // Use distinct buckets for 1-16 notification action buttons, and an
     // overflow bucket for 17 or more action buttons. Does not impact how many
     // action buttons are shown.
     UMA_HISTOGRAM_ENUMERATION("Notifications.ExtensionNotificationActionCount",
                               number_of_buttons, 17);
 
     number_of_buttons = number_of_buttons > 2 ? 2 : number_of_buttons;
 
     for (size_t i = 0; i < number_of_buttons; i++) {
       message_center::ButtonInfo info(
-          base::UTF8ToUTF16((*options->buttons)[i]->title));
+          base::UTF8ToUTF16((*options->buttons)[i].title));
       extensions::api::notifications::NotificationBitmap* icon_bitmap_ptr =
-          (*options->buttons)[i]->icon_bitmap.get();
+          (*options->buttons)[i].icon_bitmap.get();
       if (icon_bitmap_ptr) {
         NotificationConversionHelper::NotificationBitmapToGfxImage(
             image_scale, bitmap_sizes.button_icon_size, *icon_bitmap_ptr,
             &info.icon);
       }
       optional_fields.buttons.push_back(info);
     }
   }
 
   if (options->context_message) {
@@ skipping 28 matching lines @@
     optional_fields.progress = *options->progress;
     // Progress value should range from 0 to 100.
     if (optional_fields.progress < 0 || optional_fields.progress > 100) {
       SetError(kInvalidProgressValue);
       return false;
     }
   }
 
   if (has_list_items) {
     using api::notifications::NotificationItem;
-    std::vector<linked_ptr<NotificationItem> >::iterator i;
-    for (i = options->items->begin(); i != options->items->end(); ++i) {
-      message_center::NotificationItem item(
-          base::UTF8ToUTF16(i->get()->title),
-          base::UTF8ToUTF16(i->get()->message));
-      optional_fields.items.push_back(item);
+    for (const NotificationItem& api_item : *options->items) {
+      optional_fields.items.push_back(message_center::NotificationItem(
+          base::UTF8ToUTF16(api_item.title),
+          base::UTF8ToUTF16(api_item.message)));
     }
   }
 
   if (options->is_clickable.get())
     optional_fields.clickable = *options->is_clickable;
 
   NotificationsApiDelegate* api_delegate(new NotificationsApiDelegate(
       this, GetProfile(), extension_->id(), id));  // ownership is passed to
                                                    // Notification
   Notification notification(
@@ skipping 65 matching lines @@
     notification->set_timestamp(base::Time::FromJsTime(*options->event_time));
 
   if (options->buttons) {
     // Currently we allow up to 2 buttons.
     size_t number_of_buttons = options->buttons->size();
     number_of_buttons = number_of_buttons > 2 ? 2 : number_of_buttons;
 
     std::vector<message_center::ButtonInfo> buttons;
     for (size_t i = 0; i < number_of_buttons; i++) {
       message_center::ButtonInfo button(
-          base::UTF8ToUTF16((*options->buttons)[i]->title));
+          base::UTF8ToUTF16((*options->buttons)[i].title));
       extensions::api::notifications::NotificationBitmap* icon_bitmap_ptr =
-          (*options->buttons)[i]->icon_bitmap.get();
+          (*options->buttons)[i].icon_bitmap.get();
       if (icon_bitmap_ptr) {
         NotificationConversionHelper::NotificationBitmapToGfxImage(
             image_scale, bitmap_sizes.button_icon_size, *icon_bitmap_ptr,
             &button.icon);
       }
       buttons.push_back(button);
     }
     notification->set_buttons(buttons);
   }
 
@@ skipping 34 matching lines @@
 
   if (options->items.get() && options->items->size() > 0) {
     // We should have list items if and only if the type is a multiple type.
     if (notification->type() != message_center::NOTIFICATION_TYPE_MULTIPLE) {
       SetError(kExtraListItemsProvided);
       return false;
     }
 
     std::vector<message_center::NotificationItem> items;
     using api::notifications::NotificationItem;
-    std::vector<linked_ptr<NotificationItem> >::iterator i;
-    for (i = options->items->begin(); i != options->items->end(); ++i) {
-      message_center::NotificationItem item(
-          base::UTF8ToUTF16(i->get()->title),
-          base::UTF8ToUTF16(i->get()->message));
-      items.push_back(item);
+    for (const NotificationItem& api_item : *options->items) {
+      items.push_back(message_center::NotificationItem(
+          base::UTF8ToUTF16(api_item.title),
+          base::UTF8ToUTF16(api_item.message)));
     }
     notification->set_items(items);
   }
 
   // Then override if it's already set.
   if (options->is_clickable.get())
     notification->set_clickable(*options->is_clickable);
 
   g_browser_process->notification_ui_manager()->Update(*notification,
                                                        GetProfile());
@@ skipping 182 matching lines @@
           ? api::notifications::PERMISSION_LEVEL_GRANTED
           : api::notifications::PERMISSION_LEVEL_DENIED;
 
   SetResult(new base::StringValue(api::notifications::ToString(result)));
   SendResponse(true);
 
   return true;
 }
 
 }  // namespace extensions