[Extensions] Convert APIs to use movable types [7]

chrome/browser/notifications/notification_conversion_helper.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/notification_conversion_helper.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <string>
@@ skipping 43 matching lines @@
 
   options->is_clickable.reset(new bool(rich_data->clickable));
 
   options->event_time.reset(new double(rich_data->timestamp.ToDoubleT()));
 
   if (!rich_data->context_message.empty())
     options->context_message.reset(
         new std::string(base::UTF16ToUTF8(rich_data->context_message)));
 
   if (!rich_data->buttons.empty()) {
-    scoped_ptr<std::vector<
-        linked_ptr<extensions::api::notifications::NotificationButton> > >
-        button_list(new std::vector<
-            linked_ptr<extensions::api::notifications::NotificationButton> >);
-    for (size_t i = 0; i < rich_data->buttons.size(); i++) {
-      linked_ptr<extensions::api::notifications::NotificationButton> button(
-          new extensions::api::notifications::NotificationButton);
-      button->title = base::UTF16ToUTF8(rich_data->buttons[i].title);
+    options->buttons.reset(
+        new std::vector<extensions::api::notifications::NotificationButton>());
+    for (const message_center::ButtonInfo& button_info : rich_data->buttons) {
+      extensions::api::notifications::NotificationButton button;
+      button.title = base::UTF16ToUTF8(button_info.title);
 
-      if (!rich_data->buttons[i].icon.IsEmpty()) {
+      if (!button_info.icon.IsEmpty()) {
         scoped_ptr<extensions::api::notifications::NotificationBitmap> icon(
             new extensions::api::notifications::NotificationBitmap());
-        GfxImageToNotificationBitmap(&rich_data->buttons[i].icon, icon.get());
-        button->icon_bitmap = std::move(icon);
+        GfxImageToNotificationBitmap(&button_info.icon, icon.get());
+        button.icon_bitmap = std::move(icon);
       }
-      button_list->push_back(button);
+      options->buttons->push_back(std::move(button));
     }
-    options->buttons = std::move(button_list);
   }
 
   // Only image type notifications should have images.
   if (type == "image" && !rich_data->image.IsEmpty()) {
     scoped_ptr<extensions::api::notifications::NotificationBitmap> image(
         new extensions::api::notifications::NotificationBitmap());
     GfxImageToNotificationBitmap(&notification.image(), image.get());
     options->image_bitmap = std::move(image);
   } else if (type != "image" && !rich_data->image.IsEmpty()) {
     DVLOG(1) << "Only image type notifications should have images.";
   }
 
   // Only progress type notifications should have progress bars.
   if (type == "progress")
     options->progress.reset(new int(rich_data->progress));
   else if (rich_data->progress != 0)
     DVLOG(1) << "Only progress type notifications should have progress.";
 
   // Only list type notifications should have lists.
   if (type == "list" && !rich_data->items.empty()) {
-    scoped_ptr<std::vector<
-        linked_ptr<extensions::api::notifications::NotificationItem> > >
-        list(new std::vector<
-            linked_ptr<extensions::api::notifications::NotificationItem> >);
-    for (size_t j = 0; j < rich_data->items.size(); j++) {
-      linked_ptr<extensions::api::notifications::NotificationItem> item(
-          new extensions::api::notifications::NotificationItem);
-      item->title = base::UTF16ToUTF8(rich_data->items[j].title);
-      item->message = base::UTF16ToUTF8(rich_data->items[j].message);
-      list->push_back(item);
+    options->items.reset(
+        new std::vector<extensions::api::notifications::NotificationItem>());
+    for (const message_center::NotificationItem& item : rich_data->items) {
+      extensions::api::notifications::NotificationItem api_item;
+      api_item.title = base::UTF16ToUTF8(item.title);
+      api_item.message = base::UTF16ToUTF8(item.message);
+      options->items->push_back(std::move(api_item));
     }
-    options->items = std::move(list);
   } else if (type != "list" && !rich_data->items.empty()) {
     DVLOG(1) << "Only list type notifications should have lists.";
   }
 }
 
 void NotificationConversionHelper::GfxImageToNotificationBitmap(
     const gfx::Image* gfx_image,
     extensions::api::notifications::NotificationBitmap* notification_bitmap) {
   SkBitmap sk_bitmap = gfx_image->AsBitmap();
   sk_bitmap.lockPixels();
@@ skipping 84 matching lines @@
       return "image";
     case message_center::NOTIFICATION_TYPE_MULTIPLE:
       return "list";
     case message_center::NOTIFICATION_TYPE_PROGRESS:
       return "progress";
     default:
       NOTREACHED();
       return "";
   }
 }