[Extensions] Convert APIs to use movable types [7]

chrome/browser/extensions/api/log_private/syslog_parser.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/log_private/syslog_parser.h"
 
 #include <string>
 #include <vector>
 
 #include "base/logging.h"
-#include "base/memory/linked_ptr.h"
 #include "base/memory/singleton.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_tokenizer.h"
 #include "base/time/time.h"
 #include "chrome/browser/extensions/api/log_private/filter_handler.h"
 #include "chrome/browser/extensions/api/log_private/log_parser.h"
 #include "chrome/browser/extensions/api/log_private/log_private_api.h"
 #include "chrome/common/extensions/api/log_private.h"
 
 namespace extensions {
 
 namespace {
 
 const char kProcessInfoDelimiters[] = "[]:";
 
 }  // namespace
 
 SyslogParser::SyslogParser() {}
 
 SyslogParser::~SyslogParser() {}
 
 SyslogParser::Error SyslogParser::ParseEntry(
     const std::string& input,
-    std::vector<linked_ptr<api::log_private::LogEntry> >* output,
+    std::vector<api::log_private::LogEntry>* output,
     FilterHandler* filter_handler) const {
-  linked_ptr<api::log_private::LogEntry> entry(new api::log_private::LogEntry);
+  api::log_private::LogEntry entry;

[stevenjb, 2016/03/29 00:18:49]

nit: move closer to where it is used

[Devlin, 2016/03/29 14:22:39]

Done.

 
   base::StringTokenizer tokenizer(input, " ");
   if (!tokenizer.GetNext()) {
     LOG(ERROR)
         << "Error when parsing data. Expect: At least 2 tokens. Actual: 0";
     return TOKENIZE_ERROR;
   }
   std::string time = tokenizer.token();
-  if (ParseTime(time, &(entry->timestamp)) != SyslogParser::SUCCESS) {
+  if (ParseTime(time, &(entry.timestamp)) != SyslogParser::SUCCESS) {
     return SyslogParser::PARSE_ERROR;
   }
   if (!tokenizer.GetNext()) {
     LOG(ERROR)
         << "Error when parsing data. Expect: At least 2 tokens. Actual: 1";
     return TOKENIZE_ERROR;
   }
-  ParseProcess(tokenizer.token(), entry.get());
-  ParseLevel(input, entry.get());
-  entry->full_entry = input;
+  ParseProcess(tokenizer.token(), &entry);
+  ParseLevel(input, &entry);
+  entry.full_entry = input;
 
-  if (filter_handler->IsValidLogEntry(*(entry.get()))) {
-    output->push_back(entry);
+  if (filter_handler->IsValidLogEntry(entry)) {
+    output->push_back(std::move(entry));
   }
 
   return SyslogParser::SUCCESS;
 }
 
 SyslogParser::Error SyslogParser::ParseTime(const std::string& input,
                                             double* output) const {
   base::Time parsed_time;
   if (!base::Time::FromString(input.c_str(), &parsed_time)) {
     LOG(ERROR) << "Error when parsing time";
@@ skipping 32 matching lines @@
   } else if (input.find("WARN") != std::string::npos) {
     entry->level = "warning";
   } else if (input.find("INFO") != std::string::npos) {
     entry->level = "info";
   } else {
     entry->level = "unknown";
   }
 }
 
 }  // namespace extensions