Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc

Issue 1825913002: [Extensions] Convert APIs to use movable types [7] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Steven's Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc
diff --git a/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc b/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc
index 7ab2350c73382c3dfc202ce08318396106b0907b..4535c327fb89a935a9744902943dffb38598563e 100644
--- a/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc
+++ b/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc
@@ -175,10 +175,9 @@ LanguageSettingsPrivateGetSpellcheckDictionaryStatusesFunction::Run() {
LanguageSettingsPrivateDelegateFactory::GetForBrowserContext(
browser_context());
- scoped_ptr<base::ListValue> return_list(new base::ListValue());
- for (const auto& status : delegate->GetHunspellDictionaryStatuses())
- return_list->Append(status->ToValue());
- return RespondNow(OneArgument(return_list.release()));
+ return RespondNow(OneArgument(
+ language_settings_private::GetSpellcheckDictionaryStatuses::Results::
+ Create(delegate->GetHunspellDictionaryStatuses())));
}
LanguageSettingsPrivateGetSpellcheckWordsFunction::
@@ -298,8 +297,7 @@ LanguageSettingsPrivateGetTranslateTargetLanguageFunction::Run() {
// descriptors. Used for languageSettingsPrivate.getInputMethodLists().
void PopulateInputMethodListFromDescriptors(
const InputMethodDescriptors& descriptors,
- std::vector<linked_ptr<language_settings_private::InputMethod>>*
- input_methods) {
+ std::vector<language_settings_private::InputMethod>* input_methods) {
InputMethodManager* manager = InputMethodManager::Get();
InputMethodUtil* util = manager->GetInputMethodUtil();
scoped_refptr<InputMethodManager::State> ime_state =
@@ -314,17 +312,16 @@ void PopulateInputMethodListFromDescriptors(
active_ids_list.begin(), active_ids_list.end());
for (const auto& descriptor : descriptors) {
- linked_ptr<language_settings_private::InputMethod> input_method(
- new language_settings_private::InputMethod());
- input_method->id = descriptor.id();
- input_method->display_name = util->GetLocalizedDisplayName(descriptor);
- input_method->language_codes = descriptor.language_codes();
- bool enabled = active_ids.find(input_method->id) != active_ids.end();
+ language_settings_private::InputMethod input_method;
+ input_method.id = descriptor.id();
+ input_method.display_name = util->GetLocalizedDisplayName(descriptor);
+ input_method.language_codes = descriptor.language_codes();
+ bool enabled = active_ids.find(input_method.id) != active_ids.end();
if (enabled)
- input_method->enabled.reset(new bool(true));
+ input_method.enabled.reset(new bool(true));
if (descriptor.options_page_url().is_valid())
- input_method->has_options_page.reset(new bool(true));
- input_methods->push_back(input_method);
+ input_method.has_options_page.reset(new bool(true));
+ input_methods->push_back(std::move(input_method));
}
}
#endif

Powered by Google App Engine
This is Rietveld 408576698